From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFD3A3019B5; Tue, 14 Oct 2025 17:29:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760462991; cv=none; b=mUgCG9UtTe8xBCGGJzv48Zc/d1dZtHvI4jlt3/Sv5xwtCMlPNqPDjsFF3VA/CXKCyKTNFXVDCLmS/tuPI4P4yvNt6mhwCL1/40LSzXy07dnlAO7ZqhRAso3x1XaFlMZPac7IzLMDABWnY9wqXxD2ZhqZcb2Wc8pe/nXLrt7e258= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760462991; c=relaxed/simple; bh=umIOKuw4Cl92BTjFZLvn+l5GvBsnKpPNG5VctslFvvo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sIs36a+MA+0rL6Fij8+ZBMmAEA2osu2BRAl8Ew9/EIY9NObKQZr/F4EyoLA3ojbUEaW4PjAxghZMsnovog3Sd89zFFmYJ1MvcdnuB+DvSdo1kaQgi3rwUrZp/0/+jtyfYKzsT68lF/L+qNVgnSRcHGKb+VKnniDsSYM4SHdGSE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=mdWttZ76; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="mdWttZ76" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1760462979; bh=umIOKuw4Cl92BTjFZLvn+l5GvBsnKpPNG5VctslFvvo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mdWttZ76qpu6mbUf6Kj3WIQKjBlvUyV2NoAAPBwGNNWh1SGf4B2P1AGl5pYHdZmb3 Xsm705nYkO/mvz6yIyjWf/sJkxgthTOlzjjA+L03s/r35dr82hi8lCTrMdzZt45Rw9 WMd3Q2aM4FFs+rviSn8r74z2UFroU/wVDkOWkFrG8FrvJmNVVxz3SqT1Sg09J3yZet GUSzkC7YFoGTrEqeEeE06miGOXMm2rkiU8eNXEIfcyYr/ISkY6LymhP+Moo0AWv9kd V1aIiAOgdQCjqDefFIiNElIXvc6UtUxQFl88wUS4g74DgGkDPQQDitpqq+gUjJQKhA XT8sWfdCBqQYg== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id 7E45F60075; Tue, 14 Oct 2025 17:29:38 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by x201s (Postfix) with ESMTP id CCB47201BEC; Tue, 14 Oct 2025 16:27:57 +0000 (UTC) Message-ID: <168fe516-b097-4bc3-8b72-acee310216a6@fiberby.net> Date: Tue, 14 Oct 2025 16:27:53 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/6] tools: ynl-gen: bitshift the flag values in the generated code To: Jacob Keller Cc: Alexei Starovoitov , Andrew Lunn , Arkadiusz Kubalewski , Daniel Borkmann , Daniel Zahka , Donald Hunter , Jesper Dangaard Brouer , Jiri Pirko , Joe Damato , John Fastabend , Jonathan Corbet , Simon Horman , Stanislav Fomichev , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Vadim Fedorenko , Willem de Bruijn , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Abeni , Eric Dumazet , "David S. Miller" , Jakub Kicinski References: <20251013165005.83659-1-ast@fiberby.net> <20251013165005.83659-2-ast@fiberby.net> Content-Language: en-US From: =?UTF-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/13/25 11:07 PM, Jacob Keller wrote: > On 10/13/2025 9:49 AM, Asbjørn Sloth Tønnesen wrote: >> Instead of pre-computing the flag values within the code generator, >> then move the bitshift operation into the generated code. >> >> This IMHO makes the generated code read more like handwritten code. >> >> No functional changes. >> > > Could we use BIT() here? or is that not available within uAPI headers? Correct, BIT() is not exported to uAPI[1]. Thank you for the reviews! [1] [PATCH v2] checkpatch: don't complain about BIT macro in uapi https://lore.kernel.org/all/1468707033-16173-1-git-send-email-tomas.winkler@intel.com/