From: Hans de Goede <hdegoede@redhat.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Cezary Rojewski" <cezary.rojewski@intel.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Jie Yang" <yang.jie@linux.intel.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Make headphone work on Huawei Matebook D15
Date: Tue, 5 Apr 2022 11:00:44 +0200 [thread overview]
Message-ID: <168fe6c3-6a7d-4019-16e3-066caf394b8a@redhat.com> (raw)
In-Reply-To: <cover.1649147890.git.mchehab@kernel.org>
Hi,
On 4/5/22 10:44, Mauro Carvalho Chehab wrote:
> At Huawei Matebook D15 two different GPIOs are used to control the output:
> - gpio0 controls the speaker output;
> - gpio1 controls the headphone output.
>
> Changing both at the same time cause spurious events that are mis-interpreted
> as input events, causing troubles on apps. So, a delay is needed before turning
> on such gpios.
>
> With this patch, plugging a headphone causes a jack event to trigger the speaker
> supply, powering down the speaker and powering up the headphone output.
> Removing the headphone also triggers the power supply, powering up the speaker
> and powering down the headphone.
>
> Mauro Carvalho Chehab (2):
> ASoC: Intel: sof_es8336: support a separate gpio to control headphone
> ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio
There is something weird with the patches here, at least for me in Thunderbird
both patches show up as nameless attachments to emails with empty bodies.
After saving the attachments the patches look good to me, so:
Acked-by: Hans de Goede <hdegoede@redhat.com>
for the series.
Regards,
Hans
next prev parent reply other threads:[~2022-04-05 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 8:44 Mauro Carvalho Chehab
2022-04-05 8:44 ` [PATCH v2 1/2] ASoC: Intel: sof_es8336: support a separate gpio to control headphone Mauro Carvalho Chehab
2022-04-05 14:57 ` Pierre-Louis Bossart
2022-04-05 15:37 ` Mauro Carvalho Chehab
2022-04-05 8:44 ` [PATCH v2 2/2] ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio Mauro Carvalho Chehab
2022-04-05 9:00 ` Hans de Goede [this message]
2022-04-05 13:48 ` [PATCH v2 0/2] Make headphone work on Huawei Matebook D15 Mauro Carvalho Chehab
2022-04-05 13:56 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168fe6c3-6a7d-4019-16e3-066caf394b8a@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®