From: Kalle Valo <kvalo@kernel.org>
To: Dongliang Mu <dzm91@hust.edu.cn>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Dongliang Mu" <dzm91@hust.edu.cn>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] wifi: ath9k: fix printk specifier
Date: Tue, 25 Jul 2023 14:31:50 +0000 (UTC) [thread overview]
Message-ID: <169029550891.3210124.11487387565117969944.kvalo@kernel.org> (raw)
In-Reply-To: <20230723040403.296723-1-dzm91@hust.edu.cn>
Dongliang Mu <dzm91@hust.edu.cn> wrote:
> Smatch reports:
>
> ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer
> ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer
>
> Fix it by modifying %lx to %p in the printk format string.
>
> Note that with this change, the pointer address will be printed as a
> hashed value by default. This is appropriate because the kernel
> should not leak kernel pointers to user space in an informational
> message. If someone wants to see the real address for debugging
> purposes, this can be achieved with the no_hash_pointers kernel option.
>
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
061115fbfb2c wifi: ath9k: fix printk specifier
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230723040403.296723-1-dzm91@hust.edu.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-07-25 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 4:04 Dongliang Mu
2023-07-23 22:10 ` Toke Høiland-Jørgensen
2023-07-25 14:31 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169029550891.3210124.11487387565117969944.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=dzm91@hust.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®