From: Mark Brown <broonie@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Cristian Ciocaltea <cristian.ciocaltea@gmail.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Chen-Yu Tsai <wenst@chromium.org>
Cc: David Laight <David.Laight@ACULAB.COM>,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] regulator: Use bitfield values for range selectors
Date: Tue, 25 Jul 2023 21:23:50 +0100 [thread overview]
Message-ID: <169031663040.1614869.7587282767286947756.b4-ty@kernel.org> (raw)
In-Reply-To: <20230714081408.274567-1-wenst@chromium.org>
On Fri, 14 Jul 2023 16:14:07 +0800, Chen-Yu Tsai wrote:
> Right now the regulator helpers expect raw register values for the range
> selectors. This is different from the voltage selectors, which are
> normalized as bitfield values. This leads to a bit of confusion. Also,
> raw values are harder to copy from datasheets or match up with them,
> as datasheets will typically have bitfield values.
>
> Make the helpers expect bitfield values, and convert existing users. The
> field in regulator_desc is renamed to |linear_range_selectors_bitfield|.
> This is intended to cause drivers added in the same merge window and
> out-of-tree drivers using the incorrect variable and values to break,
> preventing incorrect values being used on actual hardware and potentially
> producing magic smoke.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: Use bitfield values for range selectors
commit: 269cb04b601dd8c35bbee180a9800335b93111fb
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
next prev parent reply other threads:[~2023-07-25 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 8:14 Chen-Yu Tsai
2023-07-25 20:23 ` Mark Brown [this message]
2023-08-02 6:50 ` Matti Vaittinen
2023-08-04 3:51 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169031663040.1614869.7587282767286947756.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=David.Laight@ACULAB.COM \
--cc=brgl@bgdev.pl \
--cc=cristian.ciocaltea@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®