mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Iwona Winiarska <iwona.winiarska@intel.com>
Cc: openbmc@lists.ozlabs.org, Avi Fishman <avifishman70@gmail.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Tomer Maimon <tmaimon77@gmail.com>,
	Paul Menzel <pmenzel@molgen.mpg.de>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Tyrone Ting <warp5tw@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Benjamin Fair <benjaminfair@google.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: Add bindings for peci-npcm
Date: Wed, 26 Jul 2023 14:14:02 -0600	[thread overview]
Message-ID: <169040244201.1980325.11685396975848728495.robh@kernel.org> (raw)
In-Reply-To: <20230726192740.1383740-2-iwona.winiarska@intel.com>


On Wed, 26 Jul 2023 21:27:37 +0200, Iwona Winiarska wrote:
> From: Tomer Maimon <tmaimon77@gmail.com>
> 
> Add device tree bindings for the peci-npcm controller driver.
> 
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> Signed-off-by: Tyrone Ting <warp5tw@gmail.com>
> Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com>
> Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com>
> ---
> Changes v1 -> v2:
> 
> * Renamed binding filename to match compatible (Krzysztof)
> ---
>  .../bindings/peci/nuvoton,npcm-peci.yaml      | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
 	 $id: http://devicetree.org/schemas/peci/peci-npcm.yaml
 	file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230726192740.1383740-2-iwona.winiarska@intel.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2023-07-26 20:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 19:27 [PATCH 0/4] Add support for PECI Nuvoton Iwona Winiarska
2023-07-26 19:27 ` [PATCH v2 1/4] dt-bindings: Add bindings for peci-npcm Iwona Winiarska
2023-07-26 19:39   ` Krzysztof Kozlowski
2023-07-26 20:17     ` Krzysztof Kozlowski
2023-07-26 20:14   ` Rob Herring [this message]
2023-07-26 21:21     ` Winiarska, Iwona
2023-07-26 19:27 ` [PATCH v2 2/4] peci: Add peci-npcm controller driver Iwona Winiarska
2023-07-26 19:27 ` [PATCH v2 3/4] ARM: dts: nuvoton: Add PECI controller node Iwona Winiarska
2023-07-26 19:27 ` [PATCH v2 4/4] arm64: " Iwona Winiarska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169040244201.1980325.11685396975848728495.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iwona.winiarska@intel.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=pmenzel@molgen.mpg.de \
    --cc=robh+dt@kernel.org \
    --cc=tmaimon77@gmail.com \
    --cc=venture@google.com \
    --cc=warp5tw@gmail.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®