From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E700AC001DE for ; Mon, 31 Jul 2023 10:53:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231752AbjGaKxY (ORCPT ); Mon, 31 Jul 2023 06:53:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232529AbjGaKxG (ORCPT ); Mon, 31 Jul 2023 06:53:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61B2D171A; Mon, 31 Jul 2023 03:52:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC8156100F; Mon, 31 Jul 2023 10:51:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 139D4C433C8; Mon, 31 Jul 2023 10:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690800719; bh=VRB/1XE21uItYhBv3v9HcbSnr1pNI+FT1F8W0UoZ4EQ=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=Rx3XU9T/DfTBZmTe1X/pitgrSt+EjtnzJoqNRAZuy+u5vwBhkfxh+hUZZrw8G6eyB lFooQITIfBmh8/jxn75ajaVWWyL+K/4SU45HngfcLfFTzUUGPBR5u+9IjcHh4p2VuV Gn/BP1tBlmjRqXbGir615a2nw2/EGblZCbb/EdH53HfxfeXjlH0iUF72exIeOeH8ce iI0zsUs/KwhnnNIx6Lxy7o7ockkHS9S04Qeay5vnvJcuIp6si4rRnNUb+xaSuY4dlr /lvwh+EQxuP3f465WPY0yRWJu6eDmjBQECj4Tp33HLlFzlfhS5JD89tNI3MxRd9Faa LZXL9lzdwZVlg== Received: (nullmailer pid 2405199 invoked by uid 1000); Mon, 31 Jul 2023 10:51:46 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Rob Herring To: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Jaroslav Kysela , Sylwester Nawrocki , linux-mediatek@lists.infradead.org, Rob Herring , AngeloGioacchino Del Regno , Krzysztof Kozlowski , Mark Brown , Shengjiu Wang , Cheng-Yi Chiang , Liam Girdwood , Shawn Guo , NXP Linux Team , Sascha Hauer , Fabio Estevam , Jonathan Bakker , Pengutronix Kernel Team , devicetree@vger.kernel.org, Trevor Wu , linux-kernel@vger.kernel.org, Rohit kumar , Matthias Brugger , Rao Mandadapu , Jerome Brunet , alsa-devel@alsa-project.org, Takashi Iwai , Judy Hsiao , Conor Dooley In-Reply-To: <20230731094303.185067-7-krzysztof.kozlowski@linaro.org> References: <20230731094303.185067-1-krzysztof.kozlowski@linaro.org> <20230731094303.185067-7-krzysztof.kozlowski@linaro.org> Message-Id: <169080070445.2405101.15748974095026995722.robh@kernel.org> Subject: Re: [PATCH 06/12] ASoC: dt-bindings: samsung,odroid: use common sound card Date: Mon, 31 Jul 2023 04:51:46 -0600 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Jul 2023 11:42:57 +0200, Krzysztof Kozlowski wrote: > Reference the common sound card properties and deprecate the > custom "samsung,audio-routing" in favor of generic one. This allows to > remove "model" property and make the binding closer to other sounds > cards. > > Signed-off-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/sound/samsung,odroid.yaml | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/samsung,odroid.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/sound/sound-card-common.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/samsung,odroid.example.dtb: sound: False schema does not allow {'compatible': ['hardkernel,odroid-xu3-audio'], 'model': ['Odroid-XU3'], 'audio-routing': ['Headphone Jack', 'HPL', 'Headphone Jack', 'HPR', 'IN1', 'Mic Jack', 'Mic Jack', 'MICBIAS'], 'cpu': {'sound-dai': [[4294967295, 0]]}, 'codec': {'sound-dai': [[4294967295], [4294967295]]}, '$nodename': ['sound']} from schema $id: http://devicetree.org/schemas/sound/samsung,odroid.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/samsung,odroid.example.dtb: sound: Unevaluated properties are not allowed ('audio-routing', 'model' were unexpected) from schema $id: http://devicetree.org/schemas/sound/samsung,odroid.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230731094303.185067-7-krzysztof.kozlowski@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.