From: Kalle Valo <kvalo@kernel.org>
To: Atul Raut <rauji.raut@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] ath6kl: Fix debugfs_create_dir error checking
Date: Wed, 2 Aug 2023 18:23:25 +0000 (UTC) [thread overview]
Message-ID: <169100060344.669727.8392314523199758602.kvalo@kernel.org> (raw)
In-Reply-To: <20230731024542.27248-1-rauji.raut@gmail.com>
Atul Raut <rauji.raut@gmail.com> wrote:
> The debugfs_create_dir function returns ERR_PTR
> in case of error and the correct way to check an
> error is 'IS_ERR' inline function.
> This patch will replace the null-comparison with IS_ERR
>
> This issue was found with the help of Coccinelle.
> ./drivers/net/wireless/ath/ath6kl/debug.c:1796:6-21: Wrong debugfs call error processing on line 1796
>
> Signed-off-by: Atul Raut <rauji.raut@gmail.com>
This has been already fixed:
https://git.kernel.org/kvalo/ath/c/1301783c8def
Patch set to Rejected.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230731024542.27248-1-rauji.raut@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-08-02 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 2:45 Atul Raut
[not found] ` <8b6229da-ca60-f352-f374-47f9b6d33862@web.de>
2023-07-31 6:01 ` Greg KH
2023-08-02 18:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169100060344.669727.8392314523199758602.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rauji.raut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®