From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F905C001E0 for ; Wed, 2 Aug 2023 20:49:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231922AbjHBUtK (ORCPT ); Wed, 2 Aug 2023 16:49:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230307AbjHBUtH (ORCPT ); Wed, 2 Aug 2023 16:49:07 -0400 X-Greylist: delayed 1794 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 02 Aug 2023 13:49:03 PDT Received: from 7.mo583.mail-out.ovh.net (7.mo583.mail-out.ovh.net [178.32.124.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D3221FF2 for ; Wed, 2 Aug 2023 13:49:02 -0700 (PDT) Received: from director7.ghost.mail-out.ovh.net (unknown [10.108.1.240]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 8C395267DF for ; Wed, 2 Aug 2023 20:10:56 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-6cqtb (unknown [10.110.115.108]) by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 5B7181FE0E; Wed, 2 Aug 2023 20:10:55 +0000 (UTC) Received: from etezian.org ([37.59.142.110]) by ghost-submission-6684bf9d7b-6cqtb with ESMTPSA id 90vKEk+4ymQGJQAAgyrAAA (envelope-from ); Wed, 02 Aug 2023 20:10:55 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-110S0042ae43894-5d53-42a1-98e0-905b92e0f2bc, 0C641BB37B7CC30D107EA61C426C60CA54BC1A77) smtp.auth=andi@etezian.org X-OVh-ClientIp: 178.238.172.51 From: Andi Shyti To: aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, carlos.song@nxp.com Cc: Andi Shyti , xiaoning.wang@nxp.com, haibo.chen@nxp.com, linux-imx@nxp.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] i2c: imx-lpi2c: directly return ISR when detect a NACK Date: Wed, 2 Aug 2023 22:10:31 +0200 Message-Id: <169100562766.1919254.12222013232053766298.b4-ty@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230727030347.3552992-1-carlos.song@nxp.com> References: <20230727030347.3552992-1-carlos.song@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 13281115305390246619 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedviedrkedtgdehtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeetnhguihcuufhhhihtihcuoegrnhguihdrshhhhihtiheskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrhhnpeevveeiffeifefgfeduvdetleffuefhleffjeetjeduvdevkeevhedvjeegfeetveenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecukfhppeduvdejrddtrddtrddupddujeekrddvfeekrddujedvrdehuddpfeejrdehledrudegvddruddutdenucevlhhushhtvghrufhiiigvpedvnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoegrnhguihesvghtvgiiihgrnhdrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehkeefpdhmohguvgepshhmthhpohhuth Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Thu, 27 Jul 2023 11:03:47 +0800, carlos.song@nxp.com wrote: > A NACK flag in ISR means i2c bus error. In such condition, > there is no need to do read/write operation. > > In this patch, i2c will check MSR_NDF, MSR_RDF and MSR_TDF > flag in turn, it's making mutually exclusive NACK/read/write. > So when a NACK is received(MSR_NDF), i2c will return ISR > directly and then stop i2c transfer. > > [...] Applied to i2c/andi-for-next on https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git Please note that this patch may still undergo further evaluation and the final decision will be made in collaboration with Wolfram. Thank you, Andi Patches applied =============== [1/1] i2c: imx-lpi2c: directly return ISR when detect a NACK commit: 7525bcc34ec49a39e8b56f5911431a5a2a981896