From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D0F1C04A6A for ; Thu, 3 Aug 2023 00:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232691AbjHCAFf (ORCPT ); Wed, 2 Aug 2023 20:05:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233287AbjHCAFZ (ORCPT ); Wed, 2 Aug 2023 20:05:25 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6B2C3595 for ; Wed, 2 Aug 2023 17:05:05 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-56942667393so2861317b3.2 for ; Wed, 02 Aug 2023 17:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691021104; x=1691625904; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=1B2Y9YdqEpoGLMzQwd2SRsqRVQF/VAEofv6jvEnU9GA=; b=gbvyVIM/NKrMVATt9jUOXSZ0A6hzmX1G0If61wECK9g+cG9W7gdb+D4f4KnFcgAemj b3RBWiel7mJoEHHMZHldIUOs+1zv23NN++kdiBcL9eDmHnz0UIrgNxKmgf1tlHknlwfJ 3uLUrfp9wQ6yMKznbzhb6Ls/VNQSZozzqYo1UN9qCj+LKkT6eJSHg82/ZG+aEM/mGSKq RPT3vF0iaV/sBxYcHF0MeQf0NvCC4rX93Rqck2IOfeUNrkdNoq51WqY+Jec5xRFvHHq4 y41/XAUehSEW6g+EGQ5OHHcckFKgbo3sGPgrZC/3eIVwAxEEN0ptc80b+05QB5tplEXh R97Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691021104; x=1691625904; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1B2Y9YdqEpoGLMzQwd2SRsqRVQF/VAEofv6jvEnU9GA=; b=BI37gTial/O+qHbrx6kZwq1b7obaBmUlDQldPDgoq0RLq7bTGHsR1JEQXPsCvBTnp1 t+LYVMt34YRqIHpj0NRaH7acDQwMUBqE58mh+ozWzGXImpE0v3ULdoPFTrSa1hvLAaNF LrW3rTeDY4NqMApWpTTUu9gYs6mXROCQjNdTkcEZcFN7O1ocFDdUsd1jYyU96QfBO27g 2THA/+1LqJ8B3r7OKkrG1PAdTkWUgD/+HcAQPtXyVXmlgymECFqrB2/gLSMTvazreJ63 poTubLoSDNGBZbbXYEQAPVUg+PKGpI6LKvHnOEB7RiCJ41VSg1O5Rr8GLRB0EuZSiK4P Dk5w== X-Gm-Message-State: ABy/qLZOekYr3H6VgjGBgaJyn0dKi4Vcn4WzEORjBags32SfIzPQSlEY jO0bIdeBo4IhbD+lJ1gpU8rddo9XhV4= X-Google-Smtp-Source: APBJJlE9O92/NSvZcRnj0tlPXK5inQ3aOdiQY3JF+mkag1G5Qrgvq1JgTTpGdoUncj86UbtPlK8Mwz4uVic= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:441d:0:b0:586:4eae:b942 with SMTP id r29-20020a81441d000000b005864eaeb942mr100335ywa.4.1691021104529; Wed, 02 Aug 2023 17:05:04 -0700 (PDT) Date: Wed, 2 Aug 2023 17:04:59 -0700 In-Reply-To: <20230721223711.2334426-1-seanjc@google.com> Mime-Version: 1.0 References: <20230721223711.2334426-1-seanjc@google.com> X-Mailer: git-send-email 2.41.0.585.gd2178a4bd4-goog Message-ID: <169101966149.1829182.8699224723247011152.b4-ty@google.com> Subject: Re: [PATCH] KVM: x86/mmu: Guard against collision with KVM-defined PFERR_IMPLICIT_ACCESS From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Jul 2023 15:37:11 -0700, Sean Christopherson wrote: > Add an assertion in kvm_mmu_page_fault() to ensure the error code provided > by hardware doesn't conflict with KVM's software-defined IMPLICIT_ACCESS > flag. In the unlikely scenario that future hardware starts using bit 48 > for a hardware-defined flag, preserving the bit could result in KVM > incorrectly interpreting the unknown flag as KVM's IMPLICIT_ACCESS flag. > > WARN so that any such conflict can be surfaced to KVM developers and > resolved, but otherwise ignore the bit as KVM can't possibly rely on a > flag it knows nothing about. > > [...] Applied to kvm-x86 mmu, thanks! [1/1] KVM: x86/mmu: Guard against collision with KVM-defined PFERR_IMPLICIT_ACCESS https://github.com/kvm-x86/linux/commit/3e90c27b4209 -- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes