From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbcHHPAt (ORCPT ); Mon, 8 Aug 2016 11:00:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:50415 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbcHHPAp (ORCPT ); Mon, 8 Aug 2016 11:00:45 -0400 Subject: Re: [PATCH 3/3] ARM: dts: imx6sx-udoo-neo: Add SD To: Shawn Guo References: <1467691450-22975-1-git-send-email-afaerber@suse.de> <1467691450-22975-4-git-send-email-afaerber@suse.de> <20160808141248.GI4678@tiger> Cc: linux-arm-kernel@lists.infradead.org, Mark Rutland , devicetree , Russell King , LKML , Ettore Chimenti , Rob Herring , Sascha Hauer , Fabio Estevam From: =?UTF-8?Q?Andreas_F=c3=a4rber?= X-Enigmail-Draft-Status: N1110 Organization: SUSE Linux GmbH Message-ID: <16912a4e-88c8-b11a-16bb-927ee6bf1775@suse.de> Date: Mon, 8 Aug 2016 17:00:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <20160808141248.GI4678@tiger> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 08.08.2016 um 16:12 schrieb Shawn Guo: > On Tue, Jul 05, 2016 at 06:04:10AM +0200, Andreas Färber wrote: >> Enable the SDHC node and model the SDIO_PWR GPIO as a regulator. >> Use the SD card as default trigger for the red LED. >> >> Cc: Ettore Chimenti >> Signed-off-by: Andreas Färber >> --- >> >> >> arch/arm/boot/dts/imx6sx-udoo-neo.dtsi | 34 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6sx-udoo-neo.dtsi b/arch/arm/boot/dts/imx6sx-udoo-neo.dtsi >> index e074409644d8..85f5e8606dab 100644 >> --- a/arch/arm/boot/dts/imx6sx-udoo-neo.dtsi >> +++ b/arch/arm/boot/dts/imx6sx-udoo-neo.dtsi >> @@ -56,6 +56,7 @@ >> label = "udoo-neo:red:mmc"; >> gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>; >> default-state = "off"; >> + linux,default-trigger = "mmc0"; >> }; >> >> orange { >> @@ -64,6 +65,17 @@ >> default-state = "keep"; >> }; >> }; >> + >> + sdio_pwr_reg: sd-gpio-regulator { >> + compatible = "regulator-fixed"; >> + gpio = <&gpio6 1 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + regulator-name = "SDIO_PWR"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; > > Is it correct to model SDIO power control GPIO as a boot-on and > always-on fixed regulator? It will be powered-on even when SDIO driver > is not enabled or loaded. AFAIR the issue was that the driver does not use any -supply properties where we could hook this regulator up for enabling. So modeling it as an always-on regulator seemed like the only way to ensure it gets enabled without relying on the bootloader? Note that the board boots U-Boot from SD, so it is somewhat likely that the rootfs will be on SD, too. Do you spot anything missing or wrong on the SD node below that would explain the reliability issues described in the cover letter? Regards, Andreas P.S. Thanks for picking up 1/3 - was waiting on that for preparing a v2. >> }; >> >> &cpu0 { >> @@ -230,6 +242,17 @@ >> , >> ; >> }; >> + >> + pinctrl_usdhc2: usdhc2grp { >> + fsl,pins = >> + , >> + , >> + , >> + , >> + , >> + , >> + ; /* CD */ >> + }; >> }; >> }; >> >> @@ -259,3 +282,14 @@ >> uart-has-rtscts; >> status = "disabled"; >> }; >> + >> +&usdhc2 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_usdhc2>; >> + bus-width = <4>; >> + cd-gpios = <&gpio6 2 GPIO_ACTIVE_LOW>; >> + no-1-8-v; >> + keep-power-in-suspend; >> + wakeup-source; >> + status = "okay"; >> +}; -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)