From: Rob Herring <robh@kernel.org>
To: Sriranjani P <sriranjani.p@samsung.com>
Cc: edumazet@google.com, linux-kernel@vger.kernel.org,
alexandre.torgue@foss.st.com, ravi.patel@samsung.com,
alim.akhtar@samsung.com, linux-samsung-soc@vger.kernel.org,
linux-fsd@tesla.com, conor+dt@kernel.org,
mcoquelin.stm32@gmail.com, kuba@kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
pabeni@redhat.com, robh+dt@kernel.org, pankaj.dubey@samsung.com,
richardcochran@gmail.com, krzysztof.kozlowski+dt@linaro.org,
joabreu@synopsys.com, devicetree@vger.kernel.org,
davem@davemloft.net, swathi.ks@samsung.com
Subject: Re: [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree bindings
Date: Mon, 14 Aug 2023 07:33:03 -0600 [thread overview]
Message-ID: <169201998303.2086680.8457687937999615543.robh@kernel.org> (raw)
In-Reply-To: <20230814112539.70453-2-sriranjani.p@samsung.com>
On Mon, 14 Aug 2023 16:55:36 +0530, Sriranjani P wrote:
> Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
> Ethernet YAML schema to enable the DT validation.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> Signed-off-by: Swathi K S <swathi.ks@samsung.com>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---
> .../devicetree/bindings/net/snps,dwmac.yaml | 5 +-
> .../devicetree/bindings/net/tesla,ethqos.yaml | 114 ++++++++++++++++++
> 2 files changed, 117 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/tesla,ethqos.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/tesla,ethqos.yaml: properties:clock-names: {'minItems': 5, 'maxItems': 10, 'items': [{'const': 'ptp_ref'}, {'const': 'master_bus'}, {'const': 'slave_bus'}, {'const': 'tx'}, {'const': 'rx'}, {'const': 'master2_bus'}, {'const': 'slave2_bus'}, {'const': 'eqos_rxclk_mux'}, {'const': 'eqos_phyrxclk'}, {'const': 'dout_peric_rgmii_clk'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
Documentation/devicetree/bindings/net/tesla,ethqos.example.dtb: /example-0/ethernet@14300000: failed to match any schema with compatible: ['tesla,dwc-qos-ethernet-4.21']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230814112539.70453-2-sriranjani.p@samsung.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-08-14 13:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230814112600epcas5p49fe29a3ef85e2b0158f5ee3426652fc8@epcas5p4.samsung.com>
2023-08-14 11:25 ` [PATCH v3 0/4] net: stmmac: dwc-qos: Add FSD EQoS support Sriranjani P
[not found] ` <CGME20230814112605epcas5p31aca7b23e70e8d93df11414291f7ce66@epcas5p3.samsung.com>
2023-08-14 11:25 ` [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree bindings Sriranjani P
2023-08-14 13:33 ` Rob Herring [this message]
2023-08-16 5:36 ` Sriranjani P
2023-08-16 5:40 ` Krzysztof Kozlowski
2023-08-17 14:54 ` Rob Herring
2023-08-14 19:39 ` Krzysztof Kozlowski
2023-08-16 5:58 ` Sriranjani P
2023-08-16 6:18 ` Krzysztof Kozlowski
2024-06-06 9:14 ` Swathi K S
2023-08-14 20:39 ` Andrew Lunn
2024-06-06 9:14 ` Swathi K S
2024-06-06 13:25 ` Andrew Lunn
2024-07-29 8:47 ` Swathi K S
[not found] ` <CGME20230814112612epcas5p275cffb4d3dae86c6090ca246083631c4@epcas5p2.samsung.com>
2023-08-14 11:25 ` [PATCH v3 2/4] net: stmmac: dwc-qos: Add FSD EQoS support Sriranjani P
2023-08-14 19:50 ` Krzysztof Kozlowski
2023-08-16 6:38 ` Sriranjani P
2023-08-18 9:27 ` Krzysztof Kozlowski
2024-06-06 9:14 ` Swathi K S
2024-06-06 12:16 ` Krzysztof Kozlowski
2023-08-14 20:47 ` Andrew Lunn
2024-06-06 9:16 ` Swathi K S
[not found] ` <CGME20230814112617epcas5p1bc094e9cf29da5dd7d1706e3f509ac28@epcas5p1.samsung.com>
2023-08-14 11:25 ` [PATCH v3 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC Sriranjani P
2023-08-14 19:40 ` Krzysztof Kozlowski
2023-08-14 19:56 ` Krzysztof Kozlowski
2023-08-16 6:40 ` Sriranjani P
2023-08-14 20:50 ` Andrew Lunn
2024-06-06 9:14 ` Swathi K S
2024-06-06 13:22 ` Andrew Lunn
2024-07-29 8:49 ` Swathi K S
2023-08-14 20:51 ` Andrew Lunn
[not found] ` <CGME20230814112625epcas5p1e1d488a590bfc10d4e2a06dcff166037@epcas5p1.samsung.com>
2023-08-14 11:25 ` [PATCH v3 4/4] arm64: dts: fsd: Add Ethernet support for PERIC " Sriranjani P
2023-08-14 19:41 ` Krzysztof Kozlowski
2023-08-14 19:41 ` Krzysztof Kozlowski
2023-08-16 6:26 ` Sriranjani P
2023-08-14 20:53 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169201998303.2086680.8457687937999615543.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pankaj.dubey@samsung.com \
--cc=ravi.patel@samsung.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sriranjani.p@samsung.com \
--cc=swathi.ks@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®