From: Will Deacon <will@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
Justin Stitt <justinstitt@google.com>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
linux-hardening@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2] arm64/sysreg: refactor deprecated strncpy
Date: Wed, 16 Aug 2023 19:25:26 +0100 [thread overview]
Message-ID: <169219745619.1953789.14665350088563020811.b4-ty@kernel.org> (raw)
In-Reply-To: <20230811-strncpy-arch-arm64-v2-1-ba84eabffadb@google.com>
On Fri, 11 Aug 2023 16:33:51 +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1]. Which seems to be the case here due to the forceful setting of `buf`'s
> tail to 0.
>
> A suitable replacement is `strscpy` [2] due to the fact that it
> guarantees NUL-termination on its destination buffer argument which is
> _not_ the case for `strncpy`!
>
> [...]
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64/sysreg: refactor deprecated strncpy
https://git.kernel.org/arm64/c/d232606773a0
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
next prev parent reply other threads:[~2023-08-16 18:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 16:33 Justin Stitt
2023-08-16 18:25 ` Will Deacon [this message]
2023-09-07 21:28 ` Bjorn Andersson
2023-09-08 0:04 ` Justin Stitt
2023-09-08 10:20 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169219745619.1953789.14665350088563020811.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®