From: Rob Herring <robh@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Conor Dooley <conor+dt@kernel.org>,
Eric Dumazet <edumazet@google.com>,
linux-arm-kernel@lists.infradead.org,
"David S . Miller" <davem@davemloft.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jakub Kicinski <kuba@kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
Jose Abreu <joabreu@synopsys.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
netdev@vger.kernel.org,
Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: Re: [PATCH net-next v4 6/9] dt-bindings: net: snps,dwmac: add safety irq support
Date: Thu, 17 Aug 2023 10:37:24 -0500 [thread overview]
Message-ID: <169228664449.1107185.1318874790899719478.robh@kernel.org> (raw)
In-Reply-To: <20230816152926.4093-7-jszhang@kernel.org>
On Wed, 16 Aug 2023 23:29:23 +0800, Jisheng Zhang wrote:
> The snps dwmac IP support safety features, and those Safety Feature
> Correctible Error and Uncorrectible Error irqs may be separate irqs.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.example.dtb: ethernet@16030000: interrupt-names: ['macirq', 'eth_wake_irq', 'eth_lpi'] is too long
from schema $id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.example.dtb: ethernet@16030000: Unevaluated properties are not allowed ('mdio', 'phy-handle', 'phy-mode', 'rx-fifo-depth', 'snps,axi-config', 'snps,en-tx-lpi-clockgating', 'snps,fixed-burst', 'snps,force_thresh_dma_mode', 'snps,multicast-filter-bins', 'snps,no-pbl-x8', 'snps,perfect-filter-entries', 'snps,rxpbl', 'snps,tso', 'snps,txpbl', 'stmmac-axi-config', 'tx-fifo-depth' were unexpected)
from schema $id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.example.dtb: ethernet@16030000: interrupt-names: ['macirq', 'eth_wake_irq', 'eth_lpi'] is too long
from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/snps,dwmac.example.dtb: ethernet@e0800000: interrupt-names: ['macirq', 'eth_wake_irq', 'eth_lpi'] is too long
from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230816152926.4093-7-jszhang@kernel.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-08-17 15:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 15:29 [PATCH net-next v4 0/9] net: stmmac: add new features to xgmac Jisheng Zhang
2023-08-16 15:29 ` [PATCH net-next v4 1/9] net: stmmac: correct RX COE parsing for xgmac Jisheng Zhang
2023-08-16 15:29 ` [PATCH net-next v4 2/9] net: stmmac: xgmac: add more feature parsing from hw cap Jisheng Zhang
2023-08-20 19:15 ` Andrew Lunn
2023-08-20 19:51 ` Russell King (Oracle)
2023-08-21 13:25 ` Serge Semin
2023-08-21 13:57 ` Russell King (Oracle)
2023-08-21 14:41 ` Serge Semin
2023-08-16 15:29 ` [PATCH net-next v4 3/9] net: stmmac: enlarge max rx/tx queues and channels to 16 Jisheng Zhang
2023-08-20 19:19 ` Andrew Lunn
2023-08-16 15:29 ` [PATCH net-next v4 4/9] net: stmmac: reflect multi irqs for tx/rx channels and mac and safety Jisheng Zhang
2023-08-16 15:29 ` [PATCH net-next v4 5/9] net: stmmac: xgmac: support per-channel irq Jisheng Zhang
2023-08-16 15:29 ` [PATCH net-next v4 6/9] dt-bindings: net: snps,dwmac: add safety irq support Jisheng Zhang
2023-08-17 15:37 ` Rob Herring [this message]
2023-08-16 15:29 ` [PATCH net-next v4 7/9] net: stmmac: platform: support parsing safety irqs from DT Jisheng Zhang
2023-08-20 19:28 ` Andrew Lunn
2023-08-16 15:29 ` [PATCH net-next v4 8/9] dt-bindings: net: snps,dwmac: add per channel irq support Jisheng Zhang
2023-08-16 15:29 ` [PATCH net-next v4 9/9] net: stmmac: platform: support parsing per channel irq from DT Jisheng Zhang
2023-08-20 19:29 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169228664449.1107185.1318874790899719478.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®