From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0381EE49A0 for ; Wed, 23 Aug 2023 14:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235786AbjHWOMd (ORCPT ); Wed, 23 Aug 2023 10:12:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231654AbjHWOMc (ORCPT ); Wed, 23 Aug 2023 10:12:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79F5AE4E; Wed, 23 Aug 2023 07:12:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1096362A01; Wed, 23 Aug 2023 14:12:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDC8EC433C8; Wed, 23 Aug 2023 14:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692799949; bh=aK8sjaMMZCwX9NyCciICkzG/hN1SXAT3vqzO/pjFLfU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Wy3UBr+NXNWEJ0EK7Z7zSFIDDpS79KrygtZ/M2QrDWykNrZLB+nC9TuIzBKj4M8zd 5F65MB/Z0zUhZ9oKfA9Q3KY4flQE9A8KrD9MkMU33jMOwLkYcv5kNiYlCDZbUbv4Kb 2ZbBV9iSvOMAmq6xk52O2Y/0R5luCW1sTkzQ/k0ouQ5P9weP9OODRuMCcEHcEgZDay OIK7YO++zXlzbsGUZRnglE8CIUGRkmGqCl1i5wGwnqnsYCcV2fLI46KNlS1m9LrfJj JFH45QVbUGqx6BPARaJw7K3a43L1itv8zwQ+6XAHsnH4Bp/KTX0n18o4zlkiQndEe8 vTbCdSNWmP59g== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] wireless: ath: remove unused-but-set parameter From: Kalle Valo In-Reply-To: <20230814073255.1065242-1-arnd@kernel.org> References: <20230814073255.1065242-1-arnd@kernel.org> To: Arnd Bergmann Cc: Jeff Johnson , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rg?= =?utf-8?q?ensen?= , Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Tom Rix , Aloka Dixit , Wen Gong , Ramya Gnanasekar , Karthik M , Aditya Kumar Singh , Muna Sinada , Johannes Berg , ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169279994309.1241462.4902060190559349249.kvalo@kernel.org> Date: Wed, 23 Aug 2023 14:12:24 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann wrote: > This has never been used since the driver was merged, but it now causes > a W=1 warning in recent clang versions > > drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter] > drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter] > drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter] > > Remove the bit manipulation on the otherwise unused parameter. > > Signed-off-by: Arnd Bergmann > Reviewed-by: Jeff Johnson > Acked-by: Toke Høiland-Jørgensen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 3b86f86d0f16 wifi: ath: remove unused-but-set parameter -- https://patchwork.kernel.org/project/linux-wireless/patch/20230814073255.1065242-1-arnd@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches