mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <huangshaobo3@xiaomi.com>
To: <tglx@linutronix.de>
Cc: <bhelgaas@google.com>, <chenwei29@xiaomi.com>,
	<darwi@linutronix.de>, <huangshaobo3@xiaomi.com>, <jgg@ziepe.ca>,
	<kevin.tian@intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-pci@vger.kernel.org>, <weipengliang@xiaomi.com>,
	<wengjinfei@xiaomi.com>
Subject: Re: Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc
Date: Thu, 24 Aug 2023 00:27:12 -0700	[thread overview]
Message-ID: <1692862032-37839-1-git-send-email-huangshaobo3@xiaomi.com> (raw)
In-Reply-To: <87bkexetfk.ffs@tglx>

On Wed, 23 Aug 2023 16:15:27 +0200, Thomas Gleixner wrote:
> On Fri, Aug 18 2023 at 07:26, 黄少波 wrote:

> Your patch is corrupt:

>  Applying: Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc
>  error: corrupt patch at line 12

> It's DOS mangled and whitespace damaged.

Very sorry, may have accidentally broken the patch format,
and will make sure to use plain text next time.

> > Whether to support 64-bit address status has been calculated before,
> > and the calculation result can be used directly afterwards, so use
> > msi_attrib.is_64 to avoid double calculation.

> I'm not seeing what this solves:

> > -       if (control & PCI_MSI_FLAGS_64BIT)
> > +       if (desc.pci.msi_attrib.is_64)

> Both variants resolve to a test of a bit and a conditional instruction
> on the result. It's exactly zero difference in terms of "calculation".

> So all this does is change the memory location to test. Not more not
> less. It does not generate better code and does not save anything.

It may not be appropriate to write to eliminate duplicate calculations,
can it be proposed again with clean code?

> Thanks,

>         tglx

thanks,
sparkhuang
#/******本邮件及其附件含有小米公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件! This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!******/#

  reply	other threads:[~2023-08-24  7:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  7:26 黄少波
2023-08-18  8:30 ` Ilpo Järvinen
2023-08-23 14:15 ` Thomas Gleixner
2023-08-24  7:27   ` huangshaobo3 [this message]
2023-08-24  9:04     ` Thomas Gleixner
2023-08-24 10:52       ` sparkhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1692862032-37839-1-git-send-email-huangshaobo3@xiaomi.com \
    --to=huangshaobo3@xiaomi.com \
    --cc=bhelgaas@google.com \
    --cc=chenwei29@xiaomi.com \
    --cc=darwi@linutronix.de \
    --cc=jgg@ziepe.ca \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=weipengliang@xiaomi.com \
    --cc=wengjinfei@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®