From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
To: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <srinivas.kandagatla@linaro.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <thara.gopinath@gmail.com>,
<rafael@kernel.org>, <daniel.lezcano@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<quic_srichara@quicinc.com>
Subject: [PATCH 2/7] thermal/drivers/qcom: Add new feat for soc without rpm
Date: Tue, 29 Aug 2023 00:48:22 +0530 [thread overview]
Message-ID: <1693250307-8910-3-git-send-email-quic_srichara@quicinc.com> (raw)
In-Reply-To: <1693250307-8910-1-git-send-email-quic_srichara@quicinc.com>
Some of the tsens IP like the one in IPQ5018 does not have a
RPM in the soc. Hence the early init to enable tsens would not
be done. So add a flag for that in feat and skip enable checks.
Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
---
drivers/thermal/qcom/tsens.c | 2 +-
drivers/thermal/qcom/tsens.h | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index 98c356acfe98..f39495b61952 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -974,7 +974,7 @@ int __init init_common(struct tsens_priv *priv)
ret = regmap_field_read(priv->rf[TSENS_EN], &enabled);
if (ret)
goto err_put_device;
- if (!enabled) {
+ if (!enabled && !(priv->feat->no_early_init)) {
dev_err(dev, "%s: device not enabled\n", __func__);
ret = -ENODEV;
goto err_put_device;
diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h
index 2805de1c6827..fb73e3dd0de9 100644
--- a/drivers/thermal/qcom/tsens.h
+++ b/drivers/thermal/qcom/tsens.h
@@ -505,6 +505,8 @@ enum regfield_ids {
* @srot_split: does the IP neatly splits the register space into SROT and TM,
* with SROT only being available to secure boot firmware?
* @has_watchdog: does this IP support watchdog functionality?
+ * @no_early_init: does this IP reside in a soc that does not have rpm to
+ * do pre-init.
* @max_sensors: maximum sensors supported by this version of the IP
* @trip_min_temp: minimum trip temperature supported by this version of the IP
* @trip_max_temp: maximum trip temperature supported by this version of the IP
@@ -516,6 +518,7 @@ struct tsens_features {
unsigned int adc:1;
unsigned int srot_split:1;
unsigned int has_watchdog:1;
+ unsigned int no_early_init:1;
unsigned int max_sensors;
int trip_min_temp;
int trip_max_temp;
--
2.34.1
next prev parent reply other threads:[~2023-08-28 19:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 19:18 [PATCH 0/7] Add support for IPQ5018 tsens Sricharan Ramabadhran
2023-08-28 19:18 ` [PATCH 1/7] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible Sricharan Ramabadhran
2023-08-28 19:21 ` Krzysztof Kozlowski
2023-08-29 5:59 ` Sricharan Ramabadhran
2023-08-28 19:18 ` Sricharan Ramabadhran [this message]
2023-08-28 21:17 ` [PATCH 2/7] thermal/drivers/qcom: Add new feat for soc without rpm Dmitry Baryshkov
2023-08-29 6:01 ` Sricharan Ramabadhran
2023-08-28 19:18 ` [PATCH 3/7] thermal/drivers/qcom/tsens: Add support for IPQ5018 tsens Sricharan Ramabadhran
2023-08-28 19:33 ` Krzysztof Kozlowski
2023-08-29 6:02 ` Sricharan Ramabadhran
2023-08-28 21:15 ` Dmitry Baryshkov
2023-08-30 2:20 ` Sricharan Ramabadhran
2023-08-28 19:18 ` [PATCH 4/7] thermal/drivers/qcom: Add IPQ5018 compatible Sricharan Ramabadhran
2023-08-28 19:33 ` Krzysztof Kozlowski
2023-08-29 6:03 ` Sricharan Ramabadhran
2023-08-28 19:18 ` [PATCH 5/7] dt-bindings: nvmem: Add compatible for IPQ5018 Sricharan Ramabadhran
2023-08-28 19:23 ` Krzysztof Kozlowski
2023-08-28 19:18 ` [PATCH 6/7] arm64: dts: qcom: ipq5018: Add tsens node Sricharan Ramabadhran
2023-08-28 19:25 ` Krzysztof Kozlowski
2023-08-29 6:04 ` Sricharan Ramabadhran
2023-08-28 21:19 ` Dmitry Baryshkov
2023-08-28 19:18 ` [PATCH 7/7] arm64: dts: qcom: ipq5018: Add thermal zones Sricharan Ramabadhran
2023-08-28 19:34 ` Krzysztof Kozlowski
2023-08-29 6:05 ` Sricharan Ramabadhran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1693250307-8910-3-git-send-email-quic_srichara@quicinc.com \
--to=quic_srichara@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®