From: Rob Herring <robh@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
Daniel Scally <djrscally@gmail.com>,
Helen Koike <helen.koike@collabora.com>,
linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dafna Hirschfeld <dafna@fastmail.com>,
devicetree@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v2] media: dt-bindings: Merge OV5695 into OV5693 binding
Date: Tue, 5 Sep 2023 15:54:17 -0500 [thread overview]
Message-ID: <169394725610.3997729.730832978386837870.robh@kernel.org> (raw)
In-Reply-To: <20230817202647.2179609-1-robh@kernel.org>
On Thu, 17 Aug 2023 15:26:46 -0500, Rob Herring wrote:
> The OV5695 binding is almost the same as the OV5693 binding. The only
> difference is 'clock-names' is defined for OV5695. However, the lack of
> clock-names is an omission as the Linux OV5693 driver expects the same
> 'xvclk' clock name.
>
> 'link-frequencies' is required by OV5693, but not OV5695, so make that
> conditional. Really, this shouldn't vary by device, but we're stuck with
> the existing binding use.
>
> The rockchip-isp1 binding example is missing required properties, so it
> has to be updated as well.
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Make link-frequencies conditionally required
> ---
> .../devicetree/bindings/media/i2c/ov5695.txt | 41 -------------------
> .../bindings/media/i2c/ovti,ov5693.yaml | 31 ++++++++++----
> .../bindings/media/rockchip-isp1.yaml | 1 +
> 3 files changed, 25 insertions(+), 48 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5695.txt
>
Applied, thanks!
prev parent reply other threads:[~2023-09-05 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 20:26 Rob Herring
2023-09-05 20:54 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169394725610.3997729.730832978386837870.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=dafna@fastmail.com \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=tommaso.merciai@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®