From: "tip-bot2 for Nikolay Borisov" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Nikolay Borisov <nik.borisov@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/entry] x86/entry: Rename ignore_sysret()
Date: Thu, 14 Sep 2023 11:27:04 -0000 [thread overview]
Message-ID: <169469082431.27769.8435967971182289551.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20230623111409.3047467-3-nik.borisov@suse.com>
The following commit has been merged into the x86/entry branch of tip:
Commit-ID: f71e1d2ff8e6a183bd4004bc97c453ba527b7dc6
Gitweb: https://git.kernel.org/tip/f71e1d2ff8e6a183bd4004bc97c453ba527b7dc6
Author: Nikolay Borisov <nik.borisov@suse.com>
AuthorDate: Fri, 23 Jun 2023 14:14:05 +03:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 14 Sep 2023 13:19:53 +02:00
x86/entry: Rename ignore_sysret()
The SYSCALL instruction cannot really be disabled in compatibility mode.
The best that can be done is to configure the CSTAR msr to point to a
minimal handler. Currently this handler has a rather misleading name -
ignore_sysret() as it's not really doing anything with sysret.
Give it a more descriptive name.
Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20230623111409.3047467-3-nik.borisov@suse.com
---
arch/x86/entry/entry_64.S | 4 ++--
arch/x86/include/asm/processor.h | 2 +-
arch/x86/kernel/cpu/common.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 43606de..3be71ac 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -1516,12 +1516,12 @@ SYM_CODE_END(asm_exc_nmi)
* This handles SYSCALL from 32-bit code. There is no way to program
* MSRs to fully disable 32-bit SYSCALL.
*/
-SYM_CODE_START(ignore_sysret)
+SYM_CODE_START(entry_SYSCALL32_ignore)
UNWIND_HINT_END_OF_STACK
ENDBR
mov $-ENOSYS, %eax
sysretl
-SYM_CODE_END(ignore_sysret)
+SYM_CODE_END(entry_SYSCALL32_ignore)
#endif
.pushsection .text, "ax"
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index 0086920..93cd28d 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -399,7 +399,7 @@ static inline unsigned long cpu_kernelmode_gs_base(int cpu)
return (unsigned long)per_cpu(fixed_percpu_data.gs_base, cpu);
}
-extern asmlinkage void ignore_sysret(void);
+extern asmlinkage void entry_SYSCALL32_ignore(void);
/* Save actual FS/GS selectors and bases to current->thread */
void current_save_fsgs(void);
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 382d4e6..b3f8cba 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -2087,7 +2087,7 @@ void syscall_init(void)
(unsigned long)(cpu_entry_stack(smp_processor_id()) + 1));
wrmsrl_safe(MSR_IA32_SYSENTER_EIP, (u64)entry_SYSENTER_compat);
#else
- wrmsrl_cstar((unsigned long)ignore_sysret);
+ wrmsrl_cstar((unsigned long)entry_SYSCALL32_ignore);
wrmsrl_safe(MSR_IA32_SYSENTER_CS, (u64)GDT_ENTRY_INVALID_SEG);
wrmsrl_safe(MSR_IA32_SYSENTER_ESP, 0ULL);
wrmsrl_safe(MSR_IA32_SYSENTER_EIP, 0ULL);
next prev parent reply other threads:[~2023-09-14 11:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 11:14 [PATCH v4 0/6] Make IA32_EMULATION boot time overridable Nikolay Borisov
2023-06-23 11:14 ` [PATCH v4 1/6] x86: Introduce ia32_enabled() Nikolay Borisov
2023-06-30 11:18 ` Thomas Gleixner
2023-06-30 11:44 ` Thomas Gleixner
2023-09-14 11:27 ` [tip: x86/entry] " tip-bot2 for Nikolay Borisov
2023-06-23 11:14 ` [PATCH v4 2/6] x86/entry: Rename ignore_sysret() Nikolay Borisov
2023-09-14 11:27 ` tip-bot2 for Nikolay Borisov [this message]
2023-06-23 11:14 ` [PATCH v4 3/6] x86/entry: Compile entry_SYSCALL32_ignore() unconditionally Nikolay Borisov
2023-09-14 11:27 ` [tip: x86/entry] " tip-bot2 for Nikolay Borisov
2023-06-23 11:14 ` [PATCH v4 4/6] x86/elf: Make loading of 32bit processes depend on ia32_enabled() Nikolay Borisov
2023-09-14 11:27 ` [tip: x86/entry] " tip-bot2 for Nikolay Borisov
2023-06-23 11:14 ` [PATCH v4 5/6] x86/entry: Make IA32 syscalls' availability " Nikolay Borisov
2023-09-14 11:27 ` [tip: x86/entry] " tip-bot2 for Nikolay Borisov
2023-06-23 11:14 ` [PATCH v4 6/6] x86: Make IA32_EMULATION boot time configurable Nikolay Borisov
2023-09-14 11:27 ` [tip: x86/entry] " tip-bot2 for Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169469082431.27769.8435967971182289551.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®