From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D510CCD37B3 for ; Sun, 17 Sep 2023 10:32:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234775AbjIQK1L (ORCPT ); Sun, 17 Sep 2023 06:27:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235129AbjIQK0z (ORCPT ); Sun, 17 Sep 2023 06:26:55 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBEE7B5; Sun, 17 Sep 2023 03:26:48 -0700 (PDT) Received: from pendragon.ideasonboard.com (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 580301B3C; Sun, 17 Sep 2023 12:25:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1694946312; bh=q7+ql7RcFB/pJ87nMv8ZH2E7hUNjKZng9BfK2TFzXfA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=vYDwMiSp9QPB7xt7Or7Gxx09mbnSX8blx6Pxo3KqbWXoVlczTSUX6wl2pK8eGyZFh 86au5w+oQOMCANR3GUDhmbNg92AB4AmIV/5C1Z6iYGTyil7pU39O/urRufoFECXdl+ 7T4MEFlpjl/wz4nUvgKFiCd7Hbj62/+J8HULVcWk= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230915-starch-bankable-c4102e405a73@spud> References: <20230915165946.4183839-1-kieran.bingham@ideasonboard.com> <20230915165946.4183839-2-kieran.bingham@ideasonboard.com> <20230915-starch-bankable-c4102e405a73@spud> Subject: Re: [PATCH 1/2] Documentation: dt-bindings: media: i2c: Add ROHM BU64754 bindings From: Kieran Bingham Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , open list: OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , open list , ; Illegal-Object: Syntax error in Cc: address found on vger.kernel.org: Cc: ; ^-missing semicolon to end mail group, extraneous tokens in mailbox, missing end of mailbox To: Conor Dooley Date: Sun, 17 Sep 2023 11:26:44 +0100 Message-ID: <169494640440.1922990.14245619888948093891@ping.linuxembedded.co.uk> User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Conor Dooley (2023-09-15 22:13:40) > Yo, >=20 > On Fri, Sep 15, 2023 at 05:59:45PM +0100, Kieran Bingham wrote: > > Add YAML device tree bindings for the ROHM BU64754 VCM Motor Driver for > > Camera Autofocus. > >=20 > > Signed-off-by: Kieran Bingham > > --- > > .../bindings/media/i2c/rohm,bu64754.yaml | 48 +++++++++++++++++++ > > MAINTAINERS | 7 +++ > > 2 files changed, 55 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/rohm,bu= 64754.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/media/i2c/rohm,bu64754.y= aml b/Documentation/devicetree/bindings/media/i2c/rohm,bu64754.yaml > > new file mode 100644 > > index 000000000000..22da4a46bb0c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/rohm,bu64754.yaml > > @@ -0,0 +1,48 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (C) 2023 Ideas on Board Oy. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/rohm,bu64754.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ROHM BU64754 Actuator Driver for Camera Autofocus > > + > > +maintainers: > > + - Kieran Bingham > > + > > +description: | >=20 > That | is surplus to requirements since you have no formatting to > preserve. >=20 > > + The BU64754 is an actuator driver IC which can control the actuator > > + position precisely using an internal Hall Sensor. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - rohm,bu64754 >=20 > Why such a complicated pattern when you only have one item here? > Why not just const: rohm,bu64754? These devices are really simple. I'd expect other versions/variants to be able to be covered by the same driver in the future, but I can remove this for now and simplify. >=20 > Otherwise, looks fine to me. Thanks for the review. -- Kieran