mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Jake Moilanen <moilanen@austin.ibm.com>
Cc: akpm@osdl.org, linuxppc64-dev@ozlabs.org,
	linux-kernel@vger.kernel.org, anton@samba.org,
	olof@austin.ibm.com, benh@kernel.crashing.org,
	amodra@bigpond.net.au
Subject: Re: [PATCH 1/2] No-exec support for ppc64
Date: Tue, 15 Mar 2005 09:18:04 +1100	[thread overview]
Message-ID: <16950.3484.416343.832453@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20050314155125.68dcff70.moilanen@austin.ibm.com>

Jake Moilanen writes:

> > I don't think I can push that upstream.  What happens if you leave
> > that out?
> 
> The bss and the plt are in the same segment, and plt obviously needs to
> be executable.

Yes... what I was asking was "do things actually break if you leave
that out, or does the binfmt_elf loader honour the 'x' permission on
the PT_LOAD entry for the data/bss region, meaning that it all just
works anyway?"

I did an objdump -p on some random 32-bit binaries, and they all have
"rwx" flags on the data/bss segment (the second PT_LOAD entry).  And
when I look in /proc/<pid>/maps, it seems that the heap is in fact
marked executable (this is without your patch).  So why do we need the
hack in binfmt_elf.c?

Paul.

  reply	other threads:[~2005-03-14 22:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-08 22:59 [PATCH 0/2] " Jake Moilanen
2005-03-08 23:08 ` [PATCH 1/2] " Jake Moilanen
2005-03-10  3:22   ` Olof Johansson
2005-03-10 22:25     ` Jake Moilanen
2005-03-14 10:13       ` Paul Mackerras
2005-03-14 21:51         ` Jake Moilanen
2005-03-14 22:18           ` Paul Mackerras [this message]
2005-03-15 21:51             ` Jake Moilanen
2005-03-15 22:48               ` Alan Modra
2005-03-15 23:17                 ` Jake Moilanen
2005-03-16  6:10               ` Paul Mackerras
2005-03-16 21:45                 ` Jake Moilanen
2005-03-08 23:13 ` [PATCH 2/2] " Jake Moilanen
2005-03-09  3:02   ` Benjamin Herrenschmidt
2005-03-10  3:25   ` Olof Johansson
2005-03-10  7:15     ` Benjamin Herrenschmidt
2005-03-10 22:27       ` Jake Moilanen
2005-03-10 22:44         ` Benjamin Herrenschmidt
2005-03-11 14:01           ` Jake Moilanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16950.3484.416343.832453@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=akpm@osdl.org \
    --cc=amodra@bigpond.net.au \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=moilanen@austin.ibm.com \
    --cc=olof@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®