From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F21E7D0A5 for ; Thu, 21 Sep 2023 19:02:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230518AbjIUTCb (ORCPT ); Thu, 21 Sep 2023 15:02:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbjIUTCI (ORCPT ); Thu, 21 Sep 2023 15:02:08 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30C1E80FBE; Thu, 21 Sep 2023 10:36:58 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7765CC116B3; Thu, 21 Sep 2023 08:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695283446; bh=ikVEGvz/AoDXxl7OJz8v3M6JEuj84GWYAzbM3pSuSfs=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Q0AAb/hTsyZsWcttt+LH9287e9g6+ilMDd07ifknyZdtsttuFD/C7e8WN86RofEdm UVMgUWeJlRHX1OVx0DTpFzJzn/OV51Ppg+FiMaRtZ55XYp0MY90NMR/KifyziH12cN fY+4NSCJBY8omAlRFugv8mJ87l5UCi4RvZbpHJeyOcekfqgcDsGWuLI0hHWm4hpO3u ixqDd/UTnuHp1aDa0bDudiQM+yPoqEahXZhOI1AvRrVtWpm1NSqqQ90jomTQdCDwVS b1x+bH8jl7UBlk3Wxfu0SY+aur5ipB2vp+GmJgZGgehROHGImkqJ7iBSKcv+IT4mjc 81QyDj+54D/BA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] ath9k: clean up function ath9k_hif_usb_resume From: Kalle Valo In-Reply-To: <20230905013556.2595854-1-dzm91@hust.edu.cn> References: <20230905013556.2595854-1-dzm91@hust.edu.cn> To: Dongliang Mu Cc: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , hust-os-kernel-patches@googlegroups.com, Dongliang Mu , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169528344376.1539628.7025381317587339647.kvalo@kernel.org> Date: Thu, 21 Sep 2023 08:04:05 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dongliang Mu wrote: > In ath9k_hif_usb_resume, the error handling code calls > ath9k_hif_usb_dealloc_urbs twice in different paths. > > To unify the error handling code, we move the else branch before > the if branch and drop one level of indentation of the if branch. > > In addition, move the ret variable at the end of variable declarations > to be reverse x-mas tree order. > > Note that this patch does not incur any functionability change. > > Signed-off-by: Dongliang Mu > Reviewed-by: Dan Carpenter > Acked-by: Toke Høiland-Jørgensen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. dc73b2059354 wifi: ath9k: clean up function ath9k_hif_usb_resume -- https://patchwork.kernel.org/project/linux-wireless/patch/20230905013556.2595854-1-dzm91@hust.edu.cn/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches