From: Osose Itua <osose.itua@savoirfairelinux.com>
To: netdev <netdev@vger.kernel.org>
Cc: devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Jérôme Oufella" <jerome.oufella@savoirfairelinux.com>
Subject: [PATCH 1/2] net: phy: adin: enable configuration of the LP Termination Register
Date: Tue, 16 Dec 2025 10:48:39 -0500 (EST) [thread overview]
Message-ID: <1695319092.1512780.1765900119201.JavaMail.zimbra@savoirfairelinux.com> (raw)
From 9c68d9082a9c0550891f24c5902c1f0de15de949 Mon Sep 17 00:00:00 2001
From: Osose Itua <osose.itua@savoirfairelinux.com>
Date: Fri, 14 Nov 2025 17:00:14 -0500
Subject: [PATCH 1/2] net: phy: adin: enable configuration of the LP
Termination Register
The ADIN1200/ADIN1300 provide a control bit that selects between normal
receive termination and the lowest common mode impedance for 100BASE-TX
operation. This behavior is controlled through the Low Power Termination
register (B_100_ZPTM_EN_DIMRX).
Bit 0 of this register enables normal termination when set (this is the
default), and selects the lowest common mode impedance when cleared.
Signed-off-by: Osose Itua <osose.itua@savoirfairelinux.com>
---
drivers/net/phy/adin.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
index 7fa713ca8d45..2969480a7be3 100644
--- a/drivers/net/phy/adin.c
+++ b/drivers/net/phy/adin.c
@@ -89,6 +89,9 @@
#define ADIN1300_CLOCK_STOP_REG 0x9400
#define ADIN1300_LPI_WAKE_ERR_CNT_REG 0xa000
+#define ADIN1300_B_100_ZPTM_DIMRX 0xB685
+#define ADIN1300_B_100_ZPTM_EN_DIMRX BIT(0)
+
#define ADIN1300_CDIAG_RUN 0xba1b
#define ADIN1300_CDIAG_RUN_EN BIT(0)
@@ -522,6 +525,31 @@ static int adin_config_clk_out(struct phy_device *phydev)
ADIN1300_GE_CLK_CFG_MASK, sel);
}
+static int adin_config_zptm100(struct phy_device *phydev)
+{
+ struct device *dev = &phydev->mdio.dev;
+ u8 reg;
+ int rc;
+
+ if (!(device_property_read_bool(dev, "adi,low-cmode-impedance")))
+ return 0;
+
+ /* set to 0 to configure for lowest common-mode impedance */
+ rc = phy_write_mmd(phydev, MDIO_MMD_VEND1, ADIN1300_B_100_ZPTM_DIMRX, 0x0);
+ if (rc < 0)
+ return rc;
+
+ reg = phy_read_mmd(phydev, MDIO_MMD_VEND1, ADIN1300_B_100_ZPTM_DIMRX);
+ if (reg < 0)
+ return reg;
+
+ if (reg != 0x0)
+ phydev_err(phydev,
+ "Lowest common-mode impedance configuration failed\n");
+
+ return 0;
+}
+
static int adin_config_init(struct phy_device *phydev)
{
int rc;
@@ -548,6 +576,10 @@ static int adin_config_init(struct phy_device *phydev)
if (rc < 0)
return rc;
+ rc = adin_config_zptm100(phydev);
+ if (rc < 0)
+ return rc;
+
phydev_dbg(phydev, "PHY is using mode '%s'\n",
phy_modes(phydev->interface));
next reply other threads:[~2025-12-16 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 15:48 Osose Itua [this message]
2025-12-16 15:50 ` [PATCH 2/2] dt-bindings: net: adi,adin: document LP termination property Osose Itua
2025-12-16 17:02 ` [External] : [PATCH 1/2] net: phy: adin: enable configuration of the LP Termination Register ALOK TIWARI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1695319092.1512780.1765900119201.JavaMail.zimbra@savoirfairelinux.com \
--to=osose.itua@savoirfairelinux.com \
--cc=devicetree@vger.kernel.org \
--cc=jerome.oufella@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®