mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-renesas-soc@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Antti Palosaari <crope@iki.fi>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] media: dvb-frontends: drop check because i2c_unregister_device() is NULL safe
Date: Fri, 22 Sep 2023 12:49:19 +0100	[thread overview]
Message-ID: <169538335996.2915094.5298425556148305413@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <20230922080421.35145-4-wsa+renesas@sang-engineering.com>

Quoting Wolfram Sang (2023-09-22 09:04:20)
> No need to check the argument of i2c_unregister_device() because the
> function itself does it.
> 

Having reviewed the RDACM20 patch, I think I can say this looks accurate
too.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Build tested only. Please apply to your tree.
> 
>  drivers/media/dvb-frontends/m88ds3103.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c
> index cf037b61b226..26c67ef05d13 100644
> --- a/drivers/media/dvb-frontends/m88ds3103.c
> +++ b/drivers/media/dvb-frontends/m88ds3103.c
> @@ -1920,8 +1920,7 @@ static void m88ds3103_remove(struct i2c_client *client)
>  
>         dev_dbg(&client->dev, "\n");
>  
> -       if (dev->dt_client)
> -               i2c_unregister_device(dev->dt_client);
> +       i2c_unregister_device(dev->dt_client);
>  
>         i2c_mux_del_adapters(dev->muxc);
>  
> -- 
> 2.30.2
>

  reply	other threads:[~2023-09-22 11:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22  8:04 [PATCH 0/3] treewide: " Wolfram Sang
2023-09-22  8:04 ` [PATCH 1/3] usb: typec: " Wolfram Sang
2023-09-22 10:54   ` Heikki Krogerus
2023-09-22 11:50   ` Kieran Bingham
2023-09-25  7:44   ` Geert Uytterhoeven
2023-09-22  8:04 ` [PATCH 2/3] media: i2c: " Wolfram Sang
2023-09-22  8:14   ` Kieran Bingham
2023-09-25 11:50   ` Geert Uytterhoeven
2023-09-25 11:59   ` Laurent Pinchart
2023-09-22  8:04 ` [PATCH 3/3] media: dvb-frontends: " Wolfram Sang
2023-09-22 11:49   ` Kieran Bingham [this message]
2023-09-25 11:52   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169538335996.2915094.5298425556148305413@ping.linuxembedded.co.uk \
    --to=kieran.bingham@ideasonboard.com \
    --cc=crope@iki.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®