Re: ppc64 build broke between 2.6.11-bk6 and 2.6.11-bk7

[Mikael Pettersson <mikpe@csd.uu.se>]

Mikael Pettersson writes:
 > Andrew Morton writes:
 >  > "Martin J. Bligh" <mbligh@aracnet.com> wrote:
 >  > >
 >  > > drivers/built-in.o(.text+0x182bc): In function `.matroxfb_probe':
 >  > > : undefined reference to `.mac_vmode_to_var'
 >  > > make: *** [.tmp_vmlinux1] Error 1
 >  > > 
 >  > > Anyone know what that is?
 >  > > 
 >  > 
 >  > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11/2.6.11-mm4/broken-out/fbdev-kconfig-fix-for-macmodes-and-ppc.patch
 >  > 
 >  > should fix it.
 > 
 > It seems the culprit is "matroxfb-compile-error.patch" which unconditionally adds
 > macmodes.o to the Makefile line for CONFIG_FB_MATROX. This obviously breaks on !ppc.

!pmac of course; I assume Martin configured for some kind of POWER box and not a G5.

 > The patch Andrew mentions above converts the Kconfig entry for FB_MATROX to do a
 > "select FB_MACMODES if PPC_PMAC", so dropping matroxfb-compile-error.patch should suffice.