From: Paul Mackerras <paulus@samba.org>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, akpm@osdl.org, davem@davemloft.net,
wli@holomorphy.com, riel@redhat.com, kurt@garloff.de,
Keir.Fraser@cl.cam.ac.uk, Ian.Pratt@cl.cam.ac.uk,
Christian.Limpach@cl.cam.ac.uk
Subject: Re: [PATCH 1/4] io_remap_pfn_range: add for all arch-es
Date: Sat, 19 Mar 2005 09:55:49 +1100 [thread overview]
Message-ID: <16955.23669.792362.539790@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20050318113352.0baaaf5e.rddunlap@osdl.org>
Randy.Dunlap writes:
> diff -Naurp -X /home/rddunlap/doc/dontdiff-osdl linux-2611-bk3-pv/include/asm-ppc/pgtable.h linux-2611-bk3-pfn/include/asm-ppc/pgtable.h
> --- linux-2611-bk3-pv/include/asm-ppc/pgtable.h 2005-03-07 11:02:18.000000000 -0800
> +++ linux-2611-bk3-pfn/include/asm-ppc/pgtable.h 2005-03-07 11:04:59.000000000 -0800
> @@ -735,11 +735,27 @@ static inline int io_remap_page_range(st
> phys_addr_t paddr64 = fixup_bigphys_addr(paddr, size);
> return remap_pfn_range(vma, vaddr, paddr64 >> PAGE_SHIFT, size, prot);
> }
> +
> +static inline int io_remap_pfn_range(struct vm_area_struct *vma,
> + unsigned long vaddr,
> + unsigned long pfn,
> + unsigned long size,
> + pgprot_t prot)
> +{
> + phys_addr_t paddr64 = fixup_bigphys_addr(pfn << PAGE_SHIFT, size);
> + return remap_pfn_range(vma, vaddr, pfn, size, prot);
Just by inspection, this looks like pfn should be changed to
paddr64 >> PAGE_SHIFT in that last line.
Paul.
next prev parent reply other threads:[~2005-03-18 23:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-18 19:25 [PATCH 0/4] io_remap_pfn_range: intro Randy.Dunlap
2005-03-18 19:32 ` [PATCH 3/4] io_remap_pfn_range: fix some callers for XEN Randy.Dunlap
2005-03-18 19:33 ` [PATCH 1/4] io_remap_pfn_range: add for all arch-es Randy.Dunlap
2005-03-18 22:55 ` Paul Mackerras [this message]
2005-03-18 23:19 ` Randy.Dunlap
2005-03-18 19:34 ` [PATCH 2/4] io_remap_pfn_range: convert sparc callers Randy.Dunlap
2005-03-18 19:35 ` [PATCH 4/4] io_remap_pfn_range: convert last callers Randy.Dunlap
2005-03-18 20:56 ` [PATCH 0/4] io_remap_pfn_range: intro David S. Miller
2005-04-20 1:38 ` William Lee Irwin III
2005-04-20 1:37 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16955.23669.792362.539790@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=Ian.Pratt@cl.cam.ac.uk \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=kurt@garloff.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rddunlap@osdl.org \
--cc=riel@redhat.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®