From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <david@redhat.com>,
Wanpeng Li <kernellwp@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Liran Alon" <liran.alon@oracle.com>
Subject: Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()
Date: Wed, 4 Apr 2018 19:12:13 +0200 [thread overview]
Message-ID: <16957e9b-103a-0fd5-9e2b-084e9ebc3773@redhat.com> (raw)
In-Reply-To: <9d68b1b4-04e6-46d6-70b4-6ebcb0a0c4aa@redhat.com>
On 04/04/2018 13:54, David Hildenbrand wrote:
>> +{
>> + enum emulation_result er;
>> +
>> + er = emulate_instruction(vcpu, EMULTYPE_TRAP_UD);
>> + if (er == EMULATE_USER_EXIT)
>> + return 0;
>> + if (er != EMULATE_DONE)
>> + kvm_queue_exception(vcpu, UD_VECTOR);
>> + return 1;
> I would now actually prefer
>
> if (er == EMULATE_DONE)
> return 1 ...
Why? The return statement would be duplicated.
Paolo
next prev parent reply other threads:[~2018-04-04 17:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 23:28 [PATCH v5 0/2] KVM: X86: Add Force Emulation Prefix for "emulate the next instruction" Wanpeng Li
2018-04-03 23:28 ` [PATCH v5 1/2] KVM: X86: Introduce handle_ud() Wanpeng Li
2018-04-04 11:54 ` David Hildenbrand
2018-04-04 13:28 ` Wanpeng Li
2018-04-04 17:12 ` Paolo Bonzini [this message]
2018-04-04 17:43 ` David Hildenbrand
2018-04-03 23:28 ` [PATCH v5 2/2] KVM: X86: Add Force Emulation Prefix for "emulate the next instruction" Wanpeng Li
2018-04-04 11:59 ` David Hildenbrand
2018-04-04 13:35 ` Wanpeng Li
2018-04-04 17:09 ` Paolo Bonzini
2018-04-05 0:04 ` Wanpeng Li
2018-04-05 8:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16957e9b-103a-0fd5-9e2b-084e9ebc3773@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrew.cooper3@citrix.com \
--cc=david@redhat.com \
--cc=kernellwp@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®