From: Kalle Valo <kvalo@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Stanislaw Gruszka <stf_xl@wp.pl>,
Helmut Schaa <helmut.schaa@googlemail.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] wifi: rt2x00: remove redundant check if u8 array element is less than zero
Date: Thu, 28 Sep 2023 16:24:42 +0000 (UTC) [thread overview]
Message-ID: <169591828085.3187104.685774865780206664.kvalo@kernel.org> (raw)
In-Reply-To: <20230920121240.120455-1-colin.i.king@gmail.com>
Colin Ian King <colin.i.king@gmail.com> wrote:
> The check on vga_gain[ch_idx] being less than zero is always false since
> vga_gain is a u8 array. Clean up the code by removing the check and the
> following assignment. Cleans up clang scan build warning:
>
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c:9704:26: warning:
> result of comparison of unsigned expression < 0 is always
> false [-Wtautological-unsigned-zero-compare]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Patch applied to wireless-next.git, thanks.
b2172a9330b5 wifi: rt2x00: remove redundant check if u8 array element is less than zero
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230920121240.120455-1-colin.i.king@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-09-28 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 12:12 Colin Ian King
2023-09-28 16:24 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169591828085.3187104.685774865780206664.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®