From: Rob Herring <robh@kernel.org>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc: linux-renesas-soc@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Biju Das <biju.das@bp.renesas.com>,
linux-kernel@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH v2 1/2] spi: renesas,rzv2m-csi: Add CSI (SPI) target related property
Date: Thu, 28 Sep 2023 13:32:12 -0500 [thread overview]
Message-ID: <169592593187.1030914.2646161997489930237.robh@kernel.org> (raw)
In-Reply-To: <20230927162508.328736-2-fabrizio.castro.jz@renesas.com>
On Wed, 27 Sep 2023 17:25:07 +0100, Fabrizio Castro wrote:
> The CSI IP found inside the Renesas RZ/V2M SoC can also work
> in SPI target mode.
> When working in target mode, the IP will make use of the SS
> (Slave Selection) pin, with "low" as default active level.
> The active level of SS can be changed to "high" upon setting
> property "spi-cs-high" to true.
> By default, the SS will be used in target mode, unless property
> "renesas,csi-no-ss" is set to true, in which case data will be
> shifted in and out purely based on clock activity, and the
> logic level of the SS pin will be completely ignored.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
> v1->v2: I have dropped properties renesas,csi-ss and
> renesas,csi-ss-high. I have added property
> renesas,csi-no-ss, and to configure SS as active
> high one now needs to use property spi-cs-high.
> I have also reworded the changelog to use a more
> modern terminology (host and target as opposed to
> master and slave).
>
> .../devicetree/bindings/spi/renesas,rzv2m-csi.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-09-28 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 16:25 [PATCH v2 0/2] Add RZ/V2M CSI slave support Fabrizio Castro
2023-09-27 16:25 ` [PATCH v2 1/2] spi: renesas,rzv2m-csi: Add CSI (SPI) target related property Fabrizio Castro
2023-09-28 18:32 ` Rob Herring [this message]
2023-09-27 16:25 ` [PATCH v2 2/2] spi: rzv2m-csi: Add target mode support Fabrizio Castro
2023-10-10 18:33 ` [PATCH v2 0/2] Add RZ/V2M CSI slave support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169592593187.1030914.2646161997489930237.robh@kernel.org \
--to=robh@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®