From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F30E748F0 for ; Mon, 2 Oct 2023 16:15:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238437AbjJBQPh (ORCPT ); Mon, 2 Oct 2023 12:15:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238386AbjJBQPg (ORCPT ); Mon, 2 Oct 2023 12:15:36 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A06E9E for ; Mon, 2 Oct 2023 09:15:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07FBCC433C8; Mon, 2 Oct 2023 16:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696263333; bh=AhZPFxKw6JIAmar3BTlp6KAFMwqOxLDxCPhW4rygFww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QrbkQazhVsQR0aAe2Xv3ul3hzgSf1cGt0FJwjroCzNjjAz1l1znBYWl1XOJo96pN0 idDJth42GnDGl/dVKBqf+DP0S0Oh3LjO7pTXHivmWOQmWf+ZxuP60GfIBJawDF8AF3 K6wxLOnFNcSmnQNwR1seQdWlkDmZXghcgF+PlcU5pxI70NrTTZ4qkbspQXz0Qk1+vy Al07ycPBfUFS6Nkb5Ixzkp2CmhiXWKG1c1XAqzgALMjZKpaPypirr3C00axU1yENrm qmYBDJoUcK6Ab2TARJQt4NfGGHc0dS42ZcI3dnsK8YM6xRayV81iOiCjPzYBBX94QG +AZpN55EcW4ow== Received: (nullmailer pid 1883864 invoked by uid 1000); Mon, 02 Oct 2023 16:15:31 -0000 Date: Mon, 2 Oct 2023 11:15:31 -0500 From: Rob Herring To: Chen-Yu Tsai Cc: Rob Herring , Mark Brown , Matthias Brugger , AngeloGioacchino Del Regno , Zhiyong Tao , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Lee Jones , Conor Dooley , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 03/12] regulator: dt-bindings: mt6358: Add regulator-allowed-modes property Message-ID: <169626333046.1883804.1497786674123702405.robh@kernel.org> References: <20230928085537.3246669-1-wenst@chromium.org> <20230928085537.3246669-4-wenst@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230928085537.3246669-4-wenst@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Sep 2023 16:55:26 +0800, Chen-Yu Tsai wrote: > The MT6358 PMIC allows changing operating modes for the buck regulators, > but not the LDOs. Existing device trees and the Linux implementation > already utilize this through the standard regulator-allowed-modes > property. > > The values currently used in existing device trees are simply raw > numbers. The values in the Linux driver are matching numbers defined > with macros denoting the two supported modes. Turns out these two > modes are common across parts of the larger MT63xx PMIC family. The > MT6397 regulator binding already has macros for the two modes, with > matching numbers. > > Codify the supported values for regulator-allowed-modes for the MT6358 > in the device tree binding: 0 and 1 are supported for buck regulators, > and the property should not be present for LDO regulators. Users should > use the dt-bindings/regulator/mediatek,mt6397-regulator.h header for > the macros, instead of using raw numbers. > > Signed-off-by: Chen-Yu Tsai > --- > Changes since v3: > - adapt to ldo_vxo22 and ldo_vusb movement to properties > > Changes since v2: > - new patch > > .../regulator/mediatek,mt6358-regulator.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > Reviewed-by: Rob Herring