From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1653E81E1F for ; Fri, 6 Oct 2023 17:57:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233133AbjJFR5C (ORCPT ); Fri, 6 Oct 2023 13:57:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233134AbjJFR47 (ORCPT ); Fri, 6 Oct 2023 13:56:59 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC178106; Fri, 6 Oct 2023 10:56:57 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0AAFC433C8; Fri, 6 Oct 2023 17:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696615017; bh=M7cM0uzrZk4lKMKjA93C2oMjoATI9WLt5iEp4Pa0My4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ExVRjuA7T/H0LaeJ0jyf3NZMtrc0lM6wOK+ekvS3Hq8ZCLXMYeoBcRONIckkYnR9e R9KWM6wDzcE5q6jwvZF8lMhKkQ1lgD5XgMAmF7JJPxu8HLrXCruZvJdtW+N4EFMC/7 +MgEyPdqIsG0GVwqs1Zo00lHWuag9pWExwjTRXjr6/1rfLAWPo85X4OULjN1ooa7MU QE2wvKipHSHuTUa2DvBuP+DGUrlVwrPA7dr5beW5tSBoKlXJNaQzu4hKecZwWebxPT cSOeYmHLA64elgkUGOYkMirnChTWEZcTn5lG+t94KgeZRNsGwZCdyYGcGdRGZ4Z1JF KS5ex2P3lOVhA== Received: (nullmailer pid 70487 invoked by uid 1000); Fri, 06 Oct 2023 17:56:54 -0000 Date: Fri, 6 Oct 2023 12:56:54 -0500 From: Rob Herring To: Martin Kaiser Cc: Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , linux-arm-kernel@lists.infradead.org, Conor Dooley , Linus Walleij , Magnus Damm , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH] dt-bindings: pinctrl: st,stm32: fix phandle-array warning Message-ID: <169661501435.70432.16755877986670034633.robh@kernel.org> References: <20231006082247.3830719-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006082247.3830719-1-martin@kaiser.cx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Oct 2023 10:22:48 +0200, Martin Kaiser wrote: > make CHECK_DTBS=y st/stm32f469-disco.dtb > > brings up a warning about a missing argument: > > stm32f469-disco.dtb: pinctrl@40020000: st,syscfg:0: [21, 8] is too short > > The description of the third entry indicates that this entry is optional. > The code in stm32_pctrl_dt_setup_irq parses st,syscfg and treats the third > entry as optional. It defaults to 0xf if not present in the devicetree. > > Update the schema to require at least two entries, use the same syntax as > the description of renesas,ipmmu-main in > Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml. > > Signed-off-by: Martin Kaiser > --- > > I tested the following cases, all of them returned the expected result: > > st,syscfg = <&syscfg>; (too short) > st,syscfg = <&syscfg 0x8>; (ok) > st,syscfg = <&syscfg 0x8 0x0>; (ok) > st,syscfg = <&syscfg 0x8 0x0 0x0>; (too long) > > .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by: Rob Herring