From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1314CD8CA9 for ; Tue, 10 Oct 2023 16:27:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233314AbjJJQ1u (ORCPT ); Tue, 10 Oct 2023 12:27:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229998AbjJJQ1r (ORCPT ); Tue, 10 Oct 2023 12:27:47 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D69FA99; Tue, 10 Oct 2023 09:27:44 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B793C433C7; Tue, 10 Oct 2023 16:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696955264; bh=uWXn+ySubgsLikSzKdVOCQoQctLYGPs6WUFA/M9wNbo=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=ChpBcrZz6NosHeHHlQuDmUftzhWGCTXcX/+RJ1wUGSZ0jy6Lnos9nwoRZ3XpyoVQ4 DJScejQpFrbGdanfXgrcMWBZeH9pVwgoS4sMGcCYD1OKI3JpakLHtTrRlxGmIUtP+I yThkpXhXPZ+zXmVqVU4Nlc2b/FAD3IduCzFmwU2Ga1K0iJQZ5CrNlQnHf2/AZrYPT0 fRgK0YAiDmMAJ7HUEujdE0ZMJ4g+PI2P/N6BG2LnMw7mp21EWop7HjURp9/HJOIIJm JAcr36VtaypWggAN3Aufrc75svyinUT7QO/G3HbZvL8OatWoN6/iVTb19eVT5PjgAH Aoi+lRBx65nZw== Received: (nullmailer pid 1012903 invoked by uid 1000); Tue, 10 Oct 2023 16:27:41 -0000 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: Rob Herring To: Maramaina Naresh Cc: linux-scsi@vger.kernel.org, Avri Altman , Bjorn Andersson , Alim Akhtar , Conor Dooley , Andy Gross , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Konrad Dybcio , "James E.J. Bottomley" , quic_nguyenb@quicinc.com, Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Bart Van Assche , "Martin K. Petersen" , quic_cang@quicinc.com In-Reply-To: <1696952947-18062-2-git-send-email-quic_mnaresh@quicinc.com> References: <1696952947-18062-1-git-send-email-quic_mnaresh@quicinc.com> <1696952947-18062-2-git-send-email-quic_mnaresh@quicinc.com> Message-Id: <169695526157.1012881.14879634429567807944.robh@kernel.org> Subject: Re: [PATCH V1 1/4] dt-bindings: ufs: qcom: Add qos property Date: Tue, 10 Oct 2023 11:27:41 -0500 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Oct 2023 21:19:04 +0530, Maramaina Naresh wrote: > Add bindings for per-cpu QoS for QCOM UFS. This improves random io > performance by 20% for QCOM UFS. > > Signed-off-by: Maramaina Naresh > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/ufs/qcom,ufs.yaml:83:6: [warning] wrong indentation: expected 6 but found 5 (indentation) ./Documentation/devicetree/bindings/ufs/qcom,ufs.yaml:85:6: [warning] wrong indentation: expected 6 but found 5 (indentation) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml: properties:qos: 'anyOf' conditional failed, one must be fixed: 'cpumask' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] 'type' was expected from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml: properties:qos: 'anyOf' conditional failed, one must be fixed: 'vote' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] 'type' was expected from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml: qos: missing type definition /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: Unevaluated properties are not allowed ('qos0', 'qos1' were unexpected) from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1696952947-18062-2-git-send-email-quic_mnaresh@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.