From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A57CD98C7 for ; Wed, 11 Oct 2023 06:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343866AbjJKGbi (ORCPT ); Wed, 11 Oct 2023 02:31:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbjJKGbg (ORCPT ); Wed, 11 Oct 2023 02:31:36 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F157C93 for ; Tue, 10 Oct 2023 23:31:34 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDFF4C433C7; Wed, 11 Oct 2023 06:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697005894; bh=zvpSv8bmJ90ROuqL9qzQWu4rBI3ZmjnN0yYWmOHl4i8=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=h0+TZTiZ5yN+tsWxZmFQ7Vdu+xS8Tgcbro3PWnOTfyMxELldEukn/XHur31AHGMLX dZc7JAqHCdvlH7aPHQCGWTAbAWVQa6Di/i5RG5C7Gqs7nkTndPGSkrK/CeoZTpHxOx 7JjA3Mixo3ED2YBbmCLi/V8C1UE2qaNZmuz6jEAjxUIXQ31h6ZTQZPWni0tM2sswsK FlRvua1ZSF62GIfDZUsGFR3JTJdZepcqtyIcaC/17F9LuR9WE3UiR7dTWo8eEbXPdy N8geQNXbrH+qhhgVlTjnDznm8M/Qrmow/kfxkJVUNNuYlYDn9EYYYTHgAwo7kezKge N5jEx1OZX3UHg== Received: (nullmailer pid 2911056 invoked by uid 1000); Wed, 11 Oct 2023 06:31:32 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Rob Herring To: Anand Moon Cc: Icenowy Zheng , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Rob Herring , devicetree@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , linux-usb@vger.kernel.org In-Reply-To: <20231011051152.133257-1-linux.amoon@gmail.com> References: <20231011051152.133257-1-linux.amoon@gmail.com> Message-Id: <169700589265.2911018.855796610271678067.robh@kernel.org> Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub Date: Wed, 11 Oct 2023 01:31:32 -0500 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Oct 2023 10:41:48 +0530, Anand Moon wrote: > Add the binding example for the USB3.1 Genesys Logic GL3523 > integrates with USB 3.1 Gen 1 Super Speed and USB 2.0 High-Speed > hub. > > Signed-off-by: Anand Moon > --- > New patch. > --- > .../bindings/usb/genesys,gl850g.yaml | 28 +++++++++++++++++-- > 1 file changed, 25 insertions(+), 3 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-hcd.example.dtb: hub@1: 'reset-gpios' is a required property from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-hcd.example.dtb: hub@1: 'vdd-supply' is a required property from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-hcd.example.dtb: hub@1: 'peer-hub' is a required property from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-device.example.dtb: hub@1: 'reset-gpios' is a required property from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-device.example.dtb: hub@1: 'vdd-supply' is a required property from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-device.example.dtb: hub@1: 'peer-hub' is a required property from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231011051152.133257-1-linux.amoon@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.