From: Rob Herring <robh@kernel.org>
To: Eugen Hristev <eugen.hristev@collabora.com>
Cc: angelogioacchino.delregno@collabora.com,
devicetree@vger.kernel.org, kernel@collabora.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
matthias.bgg@gmail.com, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, broonie@kernel.org,
alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] dt-bindings: arm: mediatek: convert audsys and mt2701-afe-pcm to yaml
Date: Thu, 12 Oct 2023 11:25:22 -0500 [thread overview]
Message-ID: <169712792200.1188719.6103742227495646067.robh@kernel.org> (raw)
In-Reply-To: <20231012151538.468893-1-eugen.hristev@collabora.com>
On Thu, 12 Oct 2023 18:15:38 +0300, Eugen Hristev wrote:
> Convert the mediatek,audsys binding to YAML, together with the associated
> binding bindings/sound/mt2701-afe-pcm.yaml .
>
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> ---
> Changes in v3:
> - not added Rb Conor Dooley since the patch was changed in a big essence
> - As per review by Krzysztof, also convert the mt2701-afe-pcm and reference
> the correct schema in the audsys binding.
>
> Changes in v2:
> - remove comment reference to inexistent binding
>
>
> .../bindings/arm/mediatek/mediatek,audsys.txt | 39 ---
> .../arm/mediatek/mediatek,audsys.yaml | 153 ++++++++++++
> .../bindings/sound/mt2701-afe-pcm.txt | 146 -----------
> .../bindings/sound/mt2701-afe-pcm.yaml | 229 ++++++++++++++++++
> 4 files changed, 382 insertions(+), 185 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt
> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/mt2701-afe-pcm.txt
> create mode 100644 Documentation/devicetree/bindings/sound/mt2701-afe-pcm.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/sound/mt2701-afe-pcm.yaml:11:4: [error] missing starting space in comment (comments)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231012151538.468893-1-eugen.hristev@collabora.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
prev parent reply other threads:[~2023-10-12 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 15:15 Eugen Hristev
2023-10-12 16:25 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169712792200.1188719.6103742227495646067.robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®