From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A088CDB474 for ; Wed, 18 Oct 2023 01:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344438AbjJRBRN (ORCPT ); Tue, 17 Oct 2023 21:17:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344378AbjJRBRL (ORCPT ); Tue, 17 Oct 2023 21:17:11 -0400 Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27B48F7 for ; Tue, 17 Oct 2023 18:17:09 -0700 (PDT) Received: by mail-pl1-x64a.google.com with SMTP id d9443c01a7336-1c9c939cc94so47916045ad.1 for ; Tue, 17 Oct 2023 18:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697591828; x=1698196628; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=3n3bprVeIQuT2Ng9Lf574qnCGv4o8+z0VKTT/COmX9Q=; b=KmHbK/G2xmikzjtcHD7dGMJdB8+tRHOpRptRNALPHyL2DYqRgOH1bMIeGUqK1EbOGP 4to8W9LqBAcFOwilHbSGVGTEi587ddTy0EQOrVOWET1/H4QeGAC062OMsd/CHUpWES8y nWAh21q4LbZpK+VPwFb9Ib92KqvgZzqYj807pOIph20AD0SItjG/cLyBKCaG+GB5EeQ8 ZdZbswWNo+UUBxT3LC3Jf6+hjZU9GO25jQjV0LIrgeOJA61S7rmgPFyuQvfPq4XNRMYg dlThAVfEkhPELdowbkI5Q2ozJEX3HWN+qpfgkwpb+vZOOogRN7NAkRf3V8ViPKhyeMCa B+gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697591828; x=1698196628; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3n3bprVeIQuT2Ng9Lf574qnCGv4o8+z0VKTT/COmX9Q=; b=qePN8WgUvFJqWh95UK4ZkmiZukN8ZL430/uJA6V276BgzYXkNyvvEMqvhQFn8z294T lIf6nF6b/e79De/0uR28idpr+BZ6oDKTOVbKTb6flkXcZWWit1eDJUqwBmx3bx7EGx/d nXOzzpfu7vVF3kf/x5jEGByEzs+Hi1G8LZxNYYvzJAoVKUBlQ+oIfzeJW8d0okZilV8v sMlg0OygmarTvP7VM+xpzJoe+YcJi4uRcEmqaJTCgLRmOiZxoxef+jkpbaU6QSeUN1U8 1Y6W1oF8bYSXYw8OcsunXQonYVx5R0DJGSMfOfEAFzQblUoR9DGSY//3uLFN5X3JzPnA a3yQ== X-Gm-Message-State: AOJu0YxPODxcHIb/g9VDgijwFdNyb4jUgbqopmRYV/Ldo2tHbLBbh6KU KSw1o6VtHniVbhgOrtrpG9/+9cZbse8= X-Google-Smtp-Source: AGHT+IH/h6VBuLNlyY3uWvKQWh9avfftGmDa316dg+vgdu/+7muqIhPyBmlDCjLij/7M4rsy1Exn781Z6iA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:f14c:b0:1c9:dbcf:a87c with SMTP id d12-20020a170902f14c00b001c9dbcfa87cmr63061plb.3.1697591828655; Tue, 17 Oct 2023 18:17:08 -0700 (PDT) Date: Tue, 17 Oct 2023 18:16:20 -0700 In-Reply-To: <20231017155101.40677-1-nsaenz@amazon.com> Mime-Version: 1.0 References: <20231017155101.40677-1-nsaenz@amazon.com> X-Mailer: git-send-email 2.42.0.655.g421f12c284-goog Message-ID: <169759163972.1787364.3932584247097617727.b4-ty@google.com> Subject: Re: [PATCH v3] KVM: x86: hyper-v: Don't auto-enable stimer on write from user-space From: Sean Christopherson To: Sean Christopherson , kvm@vger.kernel.org, Nicolas Saenz Julienne Cc: vkuznets@redhat.com, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, graf@amazon.de, rkagan@amazon.de, linux-kernel@vger.kernel.org, anelkz@amazon.de, stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Oct 2023 15:51:02 +0000, Nicolas Saenz Julienne wrote: > Don't apply the stimer's counter side effects when modifying its > value from user-space, as this may trigger spurious interrupts. > > For example: > - The stimer is configured in auto-enable mode. > - The stimer's count is set and the timer enabled. > - The stimer expires, an interrupt is injected. > - The VM is live migrated. > - The stimer config and count are deserialized, auto-enable is ON, the > stimer is re-enabled. > - The stimer expires right away, and injects an unwarranted interrupt. > > [...] Applied to kvm-x86 misc, thanks! [1/1] KVM: x86: hyper-v: Don't auto-enable stimer on write from user-space https://github.com/kvm-x86/linux/commit/d6800af51c76 -- https://github.com/kvm-x86/linux/tree/next