From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16FADC4167B for ; Mon, 30 Oct 2023 15:57:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233738AbjJ3P55 (ORCPT ); Mon, 30 Oct 2023 11:57:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231845AbjJ3P5z (ORCPT ); Mon, 30 Oct 2023 11:57:55 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6E91C5; Mon, 30 Oct 2023 08:57:51 -0700 (PDT) Received: from pendragon.ideasonboard.com (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 98400844; Mon, 30 Oct 2023 16:57:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698681452; bh=mjGo8QR1uzy1XFMLkNUMXlLinihEOiu5eSDDbZ8U+0M=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=CA9k6gMNEx4/eic1OhA63qm1U9s/10PGArgBaMR04XRPrBp+NC5ImBbFZzVXMCm0I HqS3YEJngrNXC2gYARtyXSgceBCKGIEykHdwxaRzniKb1OF2/4e4qTaYE8BJ+D8BBW DavoodxOM6ZS+ML5cMUOOQOpIDqbwXm6e3tcZSKc= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20231028-imx214-v3-1-cd4bf77f9690@apitzsch.eu> References: <20231028-imx214-v3-0-cd4bf77f9690@apitzsch.eu> <20231028-imx214-v3-1-cd4bf77f9690@apitzsch.eu> Subject: Re: [PATCH v3 1/4] media: i2c: imx214: Explain some magic numbers From: Kieran Bingham Cc: Jacopo Mondi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Andr=C3=A9?= Apitzsch , Ricardo Ribalda To: =?utf-8?q?Andr=C3=A9?= Apitzsch , Mauro Carvalho Chehab , Ricardo Ribalda , Sakari Ailus Date: Mon, 30 Oct 2023 15:57:45 +0000 Message-ID: <169868146535.388626.1249625693260183894@ping.linuxembedded.co.uk> User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Andr=C3=A9 Apitzsch (2023-10-28 09:41:45) > Code refinement, no functional changes. >=20 > Reviewed-by: Ricardo Ribalda Reviewed-by: Kieran Bingham > Signed-off-by: Andr=C3=A9 Apitzsch > --- > drivers/media/i2c/imx214.c | 24 +++++++++++++++++++----- > 1 file changed, 19 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c > index 4f77ea02cc27..1c30f6666d35 100644 > --- a/drivers/media/i2c/imx214.c > +++ b/drivers/media/i2c/imx214.c > @@ -19,12 +19,23 @@ > #include > #include > =20 > +#define IMX214_REG_MODE_SELECT 0x0100 > +#define IMX214_MODE_STANDBY 0x00 > +#define IMX214_MODE_STREAMING 0x01 > + > #define IMX214_DEFAULT_CLK_FREQ 24000000 > #define IMX214_DEFAULT_LINK_FREQ 480000000 > #define IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10) > #define IMX214_FPS 30 > #define IMX214_MBUS_CODE MEDIA_BUS_FMT_SRGGB10_1X10 > =20 > +/* Exposure control */ > +#define IMX214_REG_EXPOSURE 0x0202 > +#define IMX214_EXPOSURE_MIN 0 > +#define IMX214_EXPOSURE_MAX 3184 > +#define IMX214_EXPOSURE_STEP 1 > +#define IMX214_EXPOSURE_DEFAULT 3184 > + > static const char * const imx214_supply_name[] =3D { > "vdda", > "vddd", > @@ -665,7 +676,7 @@ static int imx214_set_ctrl(struct v4l2_ctrl *ctrl) > case V4L2_CID_EXPOSURE: > vals[1] =3D ctrl->val; > vals[0] =3D ctrl->val >> 8; > - ret =3D regmap_bulk_write(imx214->regmap, 0x202, vals, 2); > + ret =3D regmap_bulk_write(imx214->regmap, IMX214_REG_EXPO= SURE, vals, 2); > if (ret < 0) > dev_err(imx214->dev, "Error %d\n", ret); > ret =3D 0; > @@ -743,7 +754,7 @@ static int imx214_start_streaming(struct imx214 *imx2= 14) > dev_err(imx214->dev, "could not sync v4l2 controls\n"); > goto error; > } > - ret =3D regmap_write(imx214->regmap, 0x100, 1); > + ret =3D regmap_write(imx214->regmap, IMX214_REG_MODE_SELECT, IMX2= 14_MODE_STREAMING); > if (ret < 0) { > dev_err(imx214->dev, "could not sent start table %d\n", r= et); > goto error; > @@ -761,7 +772,7 @@ static int imx214_stop_streaming(struct imx214 *imx21= 4) > { > int ret; > =20 > - ret =3D regmap_write(imx214->regmap, 0x100, 0); > + ret =3D regmap_write(imx214->regmap, IMX214_REG_MODE_SELECT, IMX2= 14_MODE_STANDBY); > if (ret < 0) > dev_err(imx214->dev, "could not sent stop table %d\n", r= et); > =20 > @@ -991,9 +1002,12 @@ static int imx214_probe(struct i2c_client *client) > * > * Yours sincerely, Ricardo. > */ > - imx214->exposure =3D v4l2_ctrl_new_std(&imx214->ctrls, &imx214_ct= rl_ops, > + imx214->exposure =3D v4l2_ctrl_new_std(ctrl_hdlr, &imx214_ctrl_op= s, > V4L2_CID_EXPOSURE, > - 0, 3184, 1, 0x0c70); > + IMX214_EXPOSURE_MIN, > + IMX214_EXPOSURE_MAX, > + IMX214_EXPOSURE_STEP, > + IMX214_EXPOSURE_DEFAULT); > =20 > imx214->unit_size =3D v4l2_ctrl_new_std_compound(&imx214->ctrls, > NULL, >=20 > --=20 > 2.42.0 >