From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94C4E38B15F for ; Wed, 1 Apr 2026 09:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775036640; cv=none; b=lv7qK9VyiKVu/HxlNtBejY+GE8MEYhRCzVSAA9OoY+B6ZuNJnLDbNR3neuLUOvISlEkYh/wNptTXch25ubjBTHrbibjO0sabOCFbwPbExk5H0yHf6qenGyiGiLKTDfTWxrIwVag3wG9a8ictGmF7T8VG1uEtnDRhhq0Q+IKnGiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775036640; c=relaxed/simple; bh=g4afngB4z12TD/eiekfxAzdecOzu3w5MB1Q8zLgPCLo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SXvKKKgni64FLQXj9cyWleJrWC90y17yR5ZodqQbr02+NaYS9P8m1+ePDoq8igOFFFazTLb3q7PL9N6mG9y7mxeDnb01dr6OsTk0RGut4y2mPD4ytoZAmpbNobjD6PJaJGP6gUFmXQHgAgRNXx4IvopRTi4h22aDiWPecIkzDBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Itml+h1i; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TPLA7Rw7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Itml+h1i"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TPLA7Rw7" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6317dOWC1578311 for ; Wed, 1 Apr 2026 09:43:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= q5zEIap66Dc7OLWAsu4xghw/A+bEZV1aEWioMMAJ35c=; b=Itml+h1iZo/qp9DQ VIUN62PT66x3t2V79LOG0TzdAQZM9qTbcUimbLPA9Jz8t2XIvdxO1B7B6FrQ6cz2 KeYOCCVk3+0gVxD7Gp8aYOPC0YB55Q9+wXWPjKftxtDeht7qjFhsAbVQ9u5wf2VC 6tp1ykNSzDRBx6KNFWqvd6K2v9J3BG9aYSm5EHjEpM+TqHX7kbmOzfXSNoPgqLhg g1U0xR9NK/GKYKTGvBvAak+iBIG5HXu0J9Wf4RDJ08n9Tvs17itmWge58zU4fMXF zlfTrRe8UFhzxd72V6XTJBJYV61PIbaRSzP2uG9WrIJuNJ3Dd6mzVBYNfDwqIPQ5 wZGNtQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8k6kudfd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 09:43:56 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c76c2bb3149so119309a12.1 for ; Wed, 01 Apr 2026 02:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775036635; x=1775641435; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q5zEIap66Dc7OLWAsu4xghw/A+bEZV1aEWioMMAJ35c=; b=TPLA7Rw7OXZJzpoBeQJgZ+65d+ifWYIcE5s/wQ997KF+HybhIXkkEhPESlNoMJNHqg oujX5DxuUK/ZQnGaee/Cl9dzAeLvURvxxrDA5LfKmPQ+oZbLAYsYw2FgFwtUrGHKXT8B hJsTtpYhwrhp7gElVu5lNq33b+bxSNL2X9r5qScViui5EV77oQhAv/1PtJj02nzoImcH 60Z4RNQympPMi61Y/Wo3GnDrn9PzMDtPF7vgJSJVG878aF7nCxcHTpg2nZEEsj6QEuZ2 a3ulebW1zkg8ZniXjImAgF4qAKEkcVjRoElpg+O4he1kugE6LydXdM6uf3V5jD0f5JfL /Zrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775036635; x=1775641435; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q5zEIap66Dc7OLWAsu4xghw/A+bEZV1aEWioMMAJ35c=; b=ca1VWB978ign+hTiDqm4uUCQZbi9d+E8hzjy0sGDgTUS14VilOW56CZTPXUXsVv5Y3 luveky27xIYVckHR3lyNsiA6cnHbWN4QJnCL7WgW/1NXYn8Z+nB6FbFnU/NlELMMadZs wvWhMA+gIKFGYQmtPj1fv/iCTMedjQf2lJk3EY/OPPzc+03QkelwPLC4zIPEnTPt0Njw So6XKq4Et2xTC1nbFMvP7nxUVnu69zYiO+478rxyTPWROcwGY7rOt05xlBGZI41/f/GY H9yqCuQU6/ucFNhEB9OMxMMOU/7mCYAKi9U8VuBEuZCsxZmIJ4wfzP8S9Cxp1nEg2wu7 SI1g== X-Forwarded-Encrypted: i=1; AJvYcCXPwK41bODpkp5+9hUIyGr4pch5ea4EkNSOBTVS7hWx5Tf//DUTbmZE2kFeWpo3fGUGC29u1AUm21mhjF8=@vger.kernel.org X-Gm-Message-State: AOJu0YxCAg2TFh1A77maCoMOZ4BkEJ1968YEpRvV0GU4Rh7ZXvvZKkkp V0FjR3+K0X3Gbzo8IJuWNGdjIGCvvmhJHSqSQQP3sOxe8u4BEICANGGcqsaF5oXWLzMrN3d19EN sK25H8mJyAtdgL7jztwluJouxzgbk1NeXN8h02Qi24k63k0rw0GFkibHcwcODhkHEna4= X-Gm-Gg: ATEYQzyyZP3nLUFIUETKBIOsrpSR4ksKgvfaPd3BfPKNg0MQYkmfjqBVdDXXEdAXcIa i/ZCwpnlLIGz4TB6QA3oNGZ5jaV/3Gy2uX7w/9RCb3NYypKqKxPrkisG+PCIO/n0S4aNh7jT02k WeZBm4/WO6VoP4GFPE3Xgpnv2rE7cm+mfoY2uT8iPh6Uh1mA1FuJgfMrKaQzRGl9qspNGv8D63U Ecs7EP0VNUmgBdHfOg8cQK/gk/uehEsEna/z4bisXPFEiqU1ynbFrbvZjMmBwVH2C2DQwloS046 VYpWumigXMaKx8p/UNoqg/Gnc4ERAWhD5ZoqiP19YANqJ6ziCI1wKdZFpIdYPTFXIg9mY3o9Ypv NolM+Q26pCrs3/RI0VBW7GWaW8VTm7QMtQWsw0fIFnROyEUlsEs5Cpy7o4KEJevFH/6Vzx3+g7X oU1RXz34b6oMnZrRXq5g== X-Received: by 2002:a05:6a20:9329:b0:39b:84c9:3861 with SMTP id adf61e73a8af0-39ef6d8e95dmr2018578637.14.1775036635102; Wed, 01 Apr 2026 02:43:55 -0700 (PDT) X-Received: by 2002:a05:6a20:9329:b0:39b:84c9:3861 with SMTP id adf61e73a8af0-39ef6d8e95dmr2018549637.14.1775036634466; Wed, 01 Apr 2026 02:43:54 -0700 (PDT) Received: from [10.133.33.140] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76916baa53sm11599580a12.5.2026.04.01.02.43.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 02:43:54 -0700 (PDT) Message-ID: <1698c35d-cefd-48b8-8776-c7deee000afc@oss.qualcomm.com> Date: Wed, 1 Apr 2026 17:43:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 27/38] drm/msm/dp: add dp_display_get_panel() to initialize DP panel To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> <20250825-msm-dp-mst-v3-27-01faacfcdedd@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=bfJmkePB c=1 sm=1 tr=0 ts=69cce8dc cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=hAwsQ9a-qRDmXk3_GycA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA4NyBTYWx0ZWRfX1WGOwBpYbAr2 /Xzn4wPesWwE9xVOHFsGcgjBK2tYfYyS8aZDC1ZypCFXPTwsXLVZN5zKptOo3BphGj+5ErCjCMJ 2UriiHcuG66YECVTrj9aQeHpGzA3BjRLBXF7EUzsrXgAswRQs4IVlAqWGJ5bkHHE0TSJP6PUx10 Lm3GdZqaJntD70aMvAbmiDICIwZMOJOAR93PiWG+a2CKR4G/E2zAl7RnLt1uUTW8GEocyal0vM8 b1e0kolDfU85Ybv2eKDerTowOlRkyxBagLM87rwDwUaemKYFV5WhLnJmppHOZ6dLV/fZaZF52o9 mXKTMz3mY1dITyyHV/0RqIredgu7f+MXkijSxirO/DP5M17a1VSijj6gSIVdKeNopQ9sgJIcZVb wB7HVab/bs8oXbwi/lg2SeKBaYgh/2PvQaPPDCAuu+Jf6lqUd0txyMGMer0XrW6Z+qzbW00E+ig jyAO1RzAKIX3eSr6fvw== X-Proofpoint-GUID: CEkk-UzrkVIjusOd3mDvJH3O1WavUz_f X-Proofpoint-ORIG-GUID: CEkk-UzrkVIjusOd3mDvJH3O1WavUz_f X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_03,2026-04-01_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010087 On 8/27/2025 12:33 AM, Dmitry Baryshkov wrote: > On Mon, Aug 25, 2025 at 10:16:13PM +0800, Yongxing Mou wrote: >> From: Abhinav Kumar >> >> Add an API dp_display_get_panel() to initialize and return a DP >> panel to be used by DP MST module. Since some of the fields of >> DP panel are private, dp_display module needs to initialize these >> parts and return the panel back. >> >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 23 +++++++++++++++++++++++ >> drivers/gpu/drm/msm/dp/dp_display.h | 2 ++ >> 2 files changed, 25 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index 84df34306fb557341bea288ea8c13b0c81b11919..abcab3ed43b6da5ef898355cf9b7561cd9fe0404 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -632,6 +632,29 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp, u32 data) >> return 0; >> } >> >> +struct msm_dp_panel *msm_dp_display_get_panel(struct msm_dp *msm_dp_display) >> +{ >> + struct msm_dp_display_private *dp; >> + struct msm_dp_panel *dp_panel; >> + >> + dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display); >> + >> + dp_panel = msm_dp_panel_get(&dp->msm_dp_display.pdev->dev, dp->aux, dp->link, >> + dp->link_base, dp->mst2link_base, dp->mst3link_base, >> + dp->pixel_base); >> + >> + if (IS_ERR(dp->panel)) { >> + DRM_ERROR("failed to initialize panel\n"); >> + return NULL; >> + } >> + >> + memcpy(dp_panel->dpcd, dp->panel->dpcd, DP_RECEIVER_CAP_SIZE); >> + memcpy(&dp_panel->link_info, &dp->panel->link_info, >> + sizeof(dp->panel->link_info)); > > Both these lines show that link_info and dpcd belong to msm_dp_display > rather than the panel. The panel should only be describing properties of > the particular sink. > I agree with your point. This would require a larger cleanup of the panel abstraction, which seems out of scope for this series. Could we address it in a separate refactoring series? >> + >> + return dp_panel; >> +} >> + >> static void msm_dp_display_deinit_sub_modules(struct msm_dp_display_private *dp) >> { >> msm_dp_audio_put(dp->audio); >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.h b/drivers/gpu/drm/msm/dp/dp_display.h >> index b1ea027438d952c94f3ae80725c92e46c631bdb2..d5889b801d190b6f33b180ead898c1e4ebcbf8f3 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.h >> +++ b/drivers/gpu/drm/msm/dp/dp_display.h >> @@ -65,4 +65,6 @@ void msm_dp_display_unprepare(struct msm_dp *dp); >> >> int msm_dp_display_get_active_stream_cnt(struct msm_dp *msm_dp_display); >> >> +struct msm_dp_panel *msm_dp_display_get_panel(struct msm_dp *msm_dp_display); >> + >> #endif /* _DP_DISPLAY_H_ */ >> >> -- >> 2.34.1 >> >