From: Jens Axboe <axboe@kernel.dk>
To: josef@toxicpanda.com, Li Lingfeng <lilingfeng@huaweicloud.com>
Cc: linux-kernel@vger.kernel.org, hch@lst.de,
linux-block@vger.kernel.org, nbd@other.debian.org,
chaitanya.kulkarni@wdc.com, yukuai1@huaweicloud.com,
houtao1@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com,
lilingfeng3@huawei.com
Subject: Re: [PATCH v2] nbd: fix uaf in nbd_open
Date: Tue, 07 Nov 2023 08:15:31 -0700 [thread overview]
Message-ID: <169937013187.545643.6485076095455389311.b4-ty@kernel.dk> (raw)
In-Reply-To: <20231107103435.2074904-1-lilingfeng@huaweicloud.com>
On Tue, 07 Nov 2023 18:34:35 +0800, Li Lingfeng wrote:
> Commit 4af5f2e03013 ("nbd: use blk_mq_alloc_disk and
> blk_cleanup_disk") cleans up disk by blk_cleanup_disk() and it won't set
> disk->private_data as NULL as before. UAF may be triggered in nbd_open()
> if someone tries to open nbd device right after nbd_put() since nbd has
> been free in nbd_dev_remove().
>
> Fix this by implementing ->free_disk and free private data in it.
>
> [...]
Applied, thanks!
[1/1] nbd: fix uaf in nbd_open
commit: 327462725b0f759f093788dfbcb2f1fd132f956b
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2023-11-07 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 10:34 Li Lingfeng
2023-11-07 15:05 ` Josef Bacik
2023-11-07 15:15 ` Jens Axboe [this message]
2023-11-08 7:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169937013187.545643.6485076095455389311.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=houtao1@huawei.com \
--cc=josef@toxicpanda.com \
--cc=lilingfeng3@huawei.com \
--cc=lilingfeng@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®