mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Shiji Yang <yangshiji66@outlook.com>
Cc: linux-wireless@vger.kernel.org, Stanislaw Gruszka <stf_xl@wp.pl>,
	linux-kernel@vger.kernel.org,
	Shiji Yang <yangshiji66@outlook.com>
Subject: Re: [PATCH v2 1/3] wifi: rt2x00: introduce DMA busy check watchdog for rt2800
Date: Wed,  8 Nov 2023 18:14:36 +0000 (UTC)	[thread overview]
Message-ID: <169946727483.2821494.16214714839411519635.kvalo@kernel.org> (raw)
In-Reply-To: <TYAP286MB0315D7462CE08A119A99DE34BCA4A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>

Shiji Yang <yangshiji66@outlook.com> wrote:

> When I tried to fix the watchdog of rt2800, I found that sometimes
> the watchdog can not reset the hung device. This is because the
> queue is not completely stuck, it just becomes very slow. The MTK
> vendor driver for the new chip MT7603/MT7612 has a DMA busy watchdog
> to detect device hangs by checking DMA busy status. This watchdog
> implementation is something similar to it. To reduce unnecessary
> reset, we can check the INT_SOURCE_CSR register together as I found
> that when the radio hung, the RX/TX coherent interrupt will always
> stuck at triggered state.
> 
> The 'watchdog' module parameter has been extended to control all
> watchdogs(0=disabled, 1=hang watchdog, 2=DMA watchdog, 3=both). This
> new watchdog function is a slight schedule and it won't affect the
> transmission speed. So we can turn on it by default. Due to the
> INT_SOURCE_CSR register is invalid on rt2800 USB NICs, the DMA busy
> watchdog will be automatically disabled for them.
> 
> Tested on MT7620 and RT5350.
> 
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>

3 patches applied to wireless-next.git, thanks.

b1275cdd7456 wifi: rt2x00: introduce DMA busy check watchdog for rt2800
570beb6285fd wifi: rt2x00: disable RTS threshold for rt2800 by default
a11d965a218f wifi: rt2x00: restart beacon queue when hardware reset

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/TYAP286MB0315D7462CE08A119A99DE34BCA4A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


  reply	other threads:[~2023-11-08 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20231104085800.17576-1-yangshiji66@outlook.com>
2023-11-04  8:57 ` Shiji Yang
2023-11-08 18:14   ` Kalle Valo [this message]
2023-11-04  8:57 ` [PATCH v2 2/3] wifi: rt2x00: disable RTS threshold for rt2800 by default Shiji Yang
2023-11-04  8:58 ` [PATCH v2 3/3] wifi: rt2x00: restart beacon queue when hardware reset Shiji Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169946727483.2821494.16214714839411519635.kvalo@kernel.org \
    --to=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stf_xl@wp.pl \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®