From: Kalle Valo <kvalo@kernel.org>
To: Luca Weiss <luca.weiss@fairphone.com>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, ath11k@lists.infradead.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Luca Weiss <luca.weiss@fairphone.com>
Subject: Re: [PATCH] wifi: ath11k: Defer on rproc_get failure
Date: Mon, 13 Nov 2023 15:39:46 +0000 (UTC) [thread overview]
Message-ID: <169988998449.3390604.914976926360003239.kvalo@kernel.org> (raw)
In-Reply-To: <20231027-ath11k-rproc-defer-v1-1-f6b6a812cd18@fairphone.com>
Luca Weiss <luca.weiss@fairphone.com> wrote:
> If we already have gotten the rproc_handle (meaning the "qcom,rproc"
> property is defined in the devicetree), it's a valid state that the
> remoteproc module hasn't probed yet so we should defer probing instead
> of just failing to probe.
>
> This resolves a race condition when the ath11k driver probes and fails
> before the wpss remoteproc driver has probed, like the following:
>
> [ 6.232360] ath11k 17a10040.wifi: failed to get rproc
> [ 6.232366] ath11k 17a10040.wifi: failed to get rproc: -22
> [ 6.232478] ath11k: probe of 17a10040.wifi failed with error -22
> ...
> [ 6.252415] remoteproc remoteproc2: 8a00000.remoteproc is available
> [ 6.252776] remoteproc remoteproc2: powering up 8a00000.remoteproc
> [ 6.252781] remoteproc remoteproc2: Booting fw image qcom/qcm6490/fairphone5/wpss.mdt, size 7188
>
> So, defer the probe if we hit that so we can retry later once the wpss
> remoteproc is available.
>
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-01264-QCAMSLSWPLZ-1.37886.3
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
2a3ec40b98b4 wifi: ath11k: Defer on rproc_get failure
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231027-ath11k-rproc-defer-v1-1-f6b6a812cd18@fairphone.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-11-13 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 6:57 Luca Weiss
2023-10-27 8:25 ` Kalle Valo
2023-10-27 10:07 ` Luca Weiss
2023-11-13 15:37 ` Kalle Valo
2023-11-13 15:44 ` Luca Weiss
2023-11-13 15:39 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169988998449.3390604.914976926360003239.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=phone-devel@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®