From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: John Garry <john.garry@huawei.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: peterz@infradead.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, mingo@redhat.com, irogers@google.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
James Clark <James.Clark@arm.com>
Subject: Re: [PATCH 0/2] perf jevents: Enable build warnings
Date: Wed, 20 Oct 2021 13:34:09 -0300 [thread overview]
Message-ID: <16E39CDA-56B0-4A88-AD66-E2197E4E1C3B@gmail.com> (raw)
In-Reply-To: <744e6d05-eaec-49d9-1e3d-2f96d4e01e1a@huawei.com>
On October 20, 2021 11:41:01 AM GMT-03:00, John Garry <john.garry@huawei.com> wrote:
>On 20/10/2021 15:31, Arnaldo Carvalho de Melo wrote:
>> Em Sat, Oct 16, 2021 at 12:48:25AM +0800, John Garry escreveu:
>>> Currently jevents builds without any complier warning flags enabled. So
>>> use newly-defined HOSTCFLAGS, which comes from EXTRA_WARNINGS. I am not
>>> 100% confident that this is the best way, but sending out for review.
>>>
>>> Baseline is be8ecc57f180 (HEAD, acme/perf/core) perf srcline: Use
>>> long-running addr2line per DSO
>>
>> Thanks, applied.
>>
>
>Hi Arnaldo,
>
>I was going to send a v2, with changes according to James Clark's review
> - that was to add -Wall & -Werror, but they caused a problem on your
>perf/core branch as they triggered the warn fixed in commit b94729919db2.
>
>I suppose the best thing now is to send a patch on top once perf/core
>contains that commit. Let me know otherwise.
Tests are running, if something fails, then I'll have to fix it and will not make my perf/core public, so I can replace what I have with a v2, otherwise you please send a patch on top after l make it public.
- Arnaldo
>
>Thanks
next prev parent reply other threads:[~2021-10-20 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 16:48 John Garry
2021-10-15 16:48 ` [PATCH 1/2] perf jevents: Fix some would-be warnings John Garry
2021-10-15 16:48 ` [PATCH 2/2] perf jevents: Enable warnings through HOSTCFLAGS John Garry
2021-10-18 10:41 ` James Clark
2021-10-19 8:37 ` John Garry
2021-10-20 14:31 ` [PATCH 0/2] perf jevents: Enable build warnings Arnaldo Carvalho de Melo
2021-10-20 14:41 ` John Garry
2021-10-20 16:34 ` Arnaldo Carvalho de Melo [this message]
2021-10-20 17:25 ` Arnaldo Carvalho de Melo
2021-10-21 20:31 ` [RFC] Support Intel-PT code build in 32-bit arches Arnaldo Carvalho de Melo
2021-10-22 12:23 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16E39CDA-56B0-4A88-AD66-E2197E4E1C3B@gmail.com \
--to=arnaldo.melo@gmail.com \
--cc=James.Clark@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®