From: "ChristianK."@t-online.de (Christian Koenig)
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Briging doesn't compile without TCP/IP Networking
Date: Fri, 11 Jan 2002 18:46:25 +0100 [thread overview]
Message-ID: <16P5j6-16m9PEC@fwd03.sul.t-online.com> (raw)
In-Reply-To: <16On3u-1zr9mqC@fwd05.sul.t-online.com> <20020110.191713.48532251.davem@redhat.com>
In-Reply-To: <20020110.191713.48532251.davem@redhat.com>
Hi,
On Friday 11 January 2002 04:17, David S. Miller wrote:
>
> It is better to conditionalize or remove the include than to add
> CONFIG_INET ifdefs to a TCP header :-)
>
> I thought I had fixed this in current kernels...
Nope, not all.
I thing it's the right thing to remove / replace it with other
include's
Check,this one is this better ?
MfG, Christian K. (And sorry for my poor English).
diff -Nubr linux-2.4.17.orig/net/core/rtnetlink.c
linux-2.4.17/net/core/rtnetlink.c
--- linux-2.4.17.orig/net/core/rtnetlink.c Fri Dec 21 18:42:05 2001
+++ linux-2.4.17/net/core/rtnetlink.c Fri Jan 11 18:20:40 2002
@@ -45,7 +45,6 @@
#include <net/protocol.h>
#include <net/arp.h>
#include <net/route.h>
-#include <net/tcp.h>
#include <net/udp.h>
#include <net/sock.h>
#include <net/pkt_sched.h>
diff -Nubr linux-2.4.17.orig/net/unix/af_unix.c
linux-2.4.17/net/unix/af_unix.c
--- linux-2.4.17.orig/net/unix/af_unix.c Fri Dec 21 18:42:06 2001
+++ linux-2.4.17/net/unix/af_unix.c Fri Jan 11 18:23:05 2002
@@ -100,8 +100,8 @@
#include <asm/uaccess.h>
#include <linux/skbuff.h>
#include <linux/netdevice.h>
+#include <linux/rtnetlink.h>
#include <net/sock.h>
-#include <net/tcp.h>
#include <net/af_unix.h>
#include <linux/proc_fs.h>
#include <net/scm.h>
diff -Nubr linux-2.4.17.orig/net/unix/garbage.c
linux-2.4.17/net/unix/garbage.c
--- linux-2.4.17.orig/net/unix/garbage.c Sat Jun 30 04:38:26 2001
+++ linux-2.4.17/net/unix/garbage.c Fri Jan 11 18:37:55 2002
@@ -78,7 +78,6 @@
#include <linux/proc_fs.h>
#include <net/sock.h>
-#include <net/tcp.h>
#include <net/af_unix.h>
#include <net/scm.h>
next prev parent reply other threads:[~2002-01-11 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-10 21:50 Christian Koenig
2002-01-11 3:17 ` David S. Miller
2002-01-11 17:46 ` Christian Koenig [this message]
2002-01-12 7:58 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16P5j6-16m9PEC@fwd03.sul.t-online.com \
--to="christiank."@t-online.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®