From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E25C04AB6 for ; Tue, 28 May 2019 16:09:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7783208C3 for ; Tue, 28 May 2019 16:09:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Yj+KkVBD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727090AbfE1QJY (ORCPT ); Tue, 28 May 2019 12:09:24 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:38564 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbfE1QJX (ORCPT ); Tue, 28 May 2019 12:09:23 -0400 Received: by mail-ed1-f65.google.com with SMTP id g13so2762543edu.5 for ; Tue, 28 May 2019 09:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:date:message-id:in-reply-to:references:user-agent :subject:mime-version:content-transfer-encoding; bh=vRk13UBuyghmarVtMoNipwKyhaNgI5UNFGabtsK6EmA=; b=Yj+KkVBDDnZ/8AIrhCHLvON4pXXCjGtHPQEEoz8vJKL4kIw6tZM7+98BwwKEPq9FXc etAAdMu8UNml1JLKYqAsmy5Nos+w6uoFPRMqYeXDGpAPKgYVsKUSwKcjt+G7pfRPnZDa 6FHHHI+ccxt0J39FNntur+/ef6vR55E+EF5d8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:date:message-id:in-reply-to :references:user-agent:subject:mime-version :content-transfer-encoding; bh=vRk13UBuyghmarVtMoNipwKyhaNgI5UNFGabtsK6EmA=; b=mNC1xDbbevWRgxn1zh5MOg7ZTvHD9vFNHvS1lWSojOBip0CdbQiwO9UfrHtqWgxUIB 9bE1kCtAlTxB1OulsIMH0p4S2b8Bv/d/G1zbL4WqUdvZc0Fx/EhYOzHr//pgAw2SMIMQ WD0iUXiSF9RYfjOJCFvxrJAZjSv2s1JbmJzAbaK32KXmEPUEEKTpkwLlqw4I7zYplkyC oMOyNbvi3xccyPwIH3FPlSxkcD7Y5/BOjrIIYBqA/aa3Cbw0FxG0iNobdbd0IOqL73EH DQN1u4/FycCtRl8kCemOD8htTu0QKYmNILpvYq61kmL/A42y8axijRV4shDOkI6IbxpF jQNw== X-Gm-Message-State: APjAAAXNIxLc46I311O2G5SRZ46pgRSYWBG631SyK2teLdMO3pYWrCCk weoaY3N5Ba6vfnd6LJDUu59u+vZ31HlF7m2b X-Google-Smtp-Source: APXvYqwe2ChVgm/bVKPGBtODYBSt/7WwWY5djEtxSUGcNmr9IvNbLckoqL7DhwjmZsR7FQA8nMCQBw== X-Received: by 2002:aa7:cccc:: with SMTP id y12mr2546618edt.124.1559059761737; Tue, 28 May 2019 09:09:21 -0700 (PDT) Received: from [192.168.178.17] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id u47sm4347734edm.86.2019.05.28.09.09.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 May 2019 09:09:21 -0700 (PDT) From: Arend Van Spriel To: Doug Anderson , Kalle Valo CC: Madhan Mohan R , Ulf Hansson , LKML , Hante Meuleman , "David S. Miller" , netdev , "Chi-Hsien Lin" , Brian Norris , "linux-wireless" , YueHaibing , Adrian Hunter , "open list:ARM/Rockchip SoC..." , , Matthias Kaehlcke , Naveen Gupta , Wright Feng , , Double Lo , Franky Lin Date: Tue, 28 May 2019 18:09:16 +0200 Message-ID: <16aff33f3e0.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: References: <20190517225420.176893-2-dianders@chromium.org> <20190528121833.7D3A460A00@smtp.codeaurora.org> User-Agent: AquaMail/1.20.0-1451 (build: 102000001) Subject: Re: [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 28, 2019 5:52:10 PM Doug Anderson wrote: > Hi, > > On Tue, May 28, 2019 at 5:18 AM Kalle Valo wrote: >> >> Douglas Anderson wrote: >> >> > In commit 29f6589140a1 ("brcmfmac: disable command decode in >> > sdio_aos") we disabled something called "command decode in sdio_aos" >> > for a whole bunch of Broadcom SDIO WiFi parts. >> > >> > After that patch landed I find that my kernel log on >> > rk3288-veyron-minnie and rk3288-veyron-speedy is filled with: >> > brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110 >> > >> > This seems to happen every time the Broadcom WiFi transitions out of >> > sleep mode. Reverting the part of the commit that affects the WiFi on >> > my boards fixes the problem for me, so that's what this patch does. >> > >> > Note that, in general, the justification in the original commit seemed >> > a little weak. It looked like someone was testing on a SD card >> > controller that would sometimes die if there were CRC errors on the >> > bus. This used to happen back in early days of dw_mmc (the controller >> > on my boards), but we fixed it. Disabling a feature on all boards >> > just because one SD card controller is broken seems bad. ...so >> > instead of just this patch possibly the right thing to do is to fully >> > revert the original commit. >> > >> > Fixes: 29f6589140a1 ("brcmfmac: disable command decode in sdio_aos") >> > Signed-off-by: Douglas Anderson >> >> I don't see patch 2 in patchwork and I assume discussion continues. > > Apologies. I made sure to CC you individually on all the patches but > didn't think about the fact that you use patchwork to manage and so > didn't ensure all patches made it to all lists (by default each patch > gets recipients individually from get_maintainer). I'll make sure to > fix for patch set #2. If you want to see all the patches, you can at > least find them on lore.kernel.org linked from the cover: > > https://lore.kernel.org/patchwork/cover/1075373/ > > >> Please resend if/when I need to apply something. >> >> 2 patches set to Changes Requested. >> >> 10948785 [1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 > > As per Arend I'll change patch #1 to a full revert instead of a > partial revert. Arend: please yell if you want otherwise. No yelling here. If any it is expected from Cypress. Maybe good to add them specifically in Cc: Regards, Arend