From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>,
<brcm80211-dev-list.pdl@broadcom.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Double Lo <double.lo@cypress.com>,
Brian Norris <briannorris@chromium.org>,
"linux-wireless" <linux-wireless@vger.kernel.org>,
Naveen Gupta <naveen.gupta@cypress.com>,
Madhan Mohan R <madhanmohan.r@cypress.com>,
Matthias Kaehlcke <mka@chromium.org>,
Wright Feng <wright.feng@cypress.com>,
"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
netdev <netdev@vger.kernel.org>,
"brcm80211-dev-list" <brcm80211-dev-list@cypress.com>,
"David S. Miller" <davem@davemloft.net>,
Franky Lin <franky.lin@broadcom.com>,
LKML <linux-kernel@vger.kernel.org>,
Hante Meuleman <hante.meuleman@broadcom.com>,
YueHaibing <yuehaibing@huawei.com>,
Michael Trimarchi <michael@amarulasolutions.com>
Subject: Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail
Date: Fri, 07 Jun 2019 20:56:43 +0200 [thread overview]
Message-ID: <16b334cd9f8.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> (raw)
In-Reply-To: <CAD=FV=XVmCYWe9rtTFakq8yu67R-97EPyAHWck+o3dRXzHCchQ@mail.gmail.com>
On June 7, 2019 8:06:30 PM Doug Anderson <dianders@chromium.org> wrote:
> Hi,
>
> On Fri, Jun 7, 2019 at 6:32 AM Arend Van Spriel
> <arend.vanspriel@broadcom.com> wrote:
>>
>> Right. I know it supports initial tuning, but I'm not sure about subsequent
>> retuning initiated by the host controller.
>
> My evidence says that it supports subsequent tuning. In fact, without
> this series my logs would be filled with:
>
> dwmmc_rockchip ff0d0000.dwmmc: Successfully tuned phase to XYZ
>
> ...where the phase varied by a few degrees each time. AKA: it was
> retuning over and over again and getting sane results which implies
> that the tuning was working just fine.
Ok. Thanks for confirming this.
Regards,
Arend
next prev parent reply other threads:[~2019-06-07 18:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 18:37 [PATCH v2 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from idle Douglas Anderson
2019-06-03 18:37 ` [PATCH v2 1/3] Revert "brcmfmac: disable command decode in sdio_aos" Douglas Anderson
2019-06-03 18:37 ` [PATCH v2 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors Douglas Anderson
2019-06-05 7:54 ` Arend Van Spriel
2019-06-05 22:51 ` Doug Anderson
2019-06-03 18:37 ` [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail Douglas Anderson
2019-06-06 13:59 ` Adrian Hunter
2019-06-06 21:37 ` Doug Anderson
2019-06-07 5:12 ` Arend Van Spriel
2019-06-07 12:38 ` Adrian Hunter
2019-06-07 13:32 ` Arend Van Spriel
2019-06-07 18:06 ` Doug Anderson
2019-06-07 18:56 ` Arend Van Spriel [this message]
2019-06-07 12:28 ` Adrian Hunter
2019-06-07 18:00 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16b334cd9f8.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=adrian.hunter@intel.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=briannorris@chromium.org \
--cc=chi-hsien.lin@cypress.com \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=double.lo@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=madhanmohan.r@cypress.com \
--cc=michael@amarulasolutions.com \
--cc=mka@chromium.org \
--cc=naveen.gupta@cypress.com \
--cc=netdev@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wright.feng@cypress.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®