From: Leonardo Bras <leobras.c@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: lkcamp@lists.libreplanetbr.org, Borislav Petkov <bp@alien8.de>,
David.Laight@aculab.com, Andy Lutomirski <luto@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
helen@koikeco.de, Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] modpost: Changes parameter name to avoid shadowing.
Date: Wed, 31 Oct 2018 20:24:01 -0300 [thread overview]
Message-ID: <16b6518d7b36787e1813d62336b661bf603d54b2.camel@gmail.com> (raw)
In-Reply-To: <CAK7LNAQzgdFPpwHEtfDazLd2jAhNy8=f_4mvOQMWfOWCb07E1Q@mail.gmail.com>
Em seg, 2018-10-29 às 01:42 +0900, Masahiro Yamada escreveu:
> On Wed, Oct 24, 2018 at 1:05 PM Leonardo Bras <leobras.c@gmail.com>
> wrote:
> > Changes the parameter name to avoid shadowing a variable.
> >
> > Signed-off-by: Leonardo Bras <leobras.c@gmail.com>
>
> For this one, I'd rather like to see code refactoring
> than renaming the variable.
>
> I will take a closer look.
What do you suggest to refactor?
I volunteer for this work.
Leonardo Bras
next prev parent reply other threads:[~2018-10-31 23:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 4:03 [PATCH v3 0/5] Adds -Wshadow on KBUILD_HOSTCFLAGS and fix warnings Leonardo Bras
2018-10-24 4:03 ` [PATCH v3 1/5] x86/vdso: Renames variable to fix shadow warning Leonardo Bras
2018-10-28 16:34 ` Masahiro Yamada
2018-10-24 4:03 ` [PATCH v3 2/5] kbuild: Removes unnecessary shadowed local variable Leonardo Bras
2018-10-28 16:36 ` Masahiro Yamada
2018-10-30 0:31 ` Leonardo Bras
2018-10-24 4:03 ` [PATCH v3 3/5] Creates macro to avoid variable shadowing Leonardo Bras
2018-10-24 4:03 ` [PATCH v3 4/5] modpost: Changes parameter name to avoid shadowing Leonardo Bras
2018-10-28 16:42 ` Masahiro Yamada
2018-10-31 23:24 ` Leonardo Bras [this message]
2018-11-01 3:31 ` Leonardo Bras
2018-10-24 4:03 ` [PATCH v3 5/5] Adds -Wshadow on KBUILD_HOSTCFLAGS Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16b6518d7b36787e1813d62336b661bf603d54b2.camel@gmail.com \
--to=leobras.c@gmail.com \
--cc=David.Laight@aculab.com \
--cc=bp@alien8.de \
--cc=helen@koikeco.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=luto@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®