From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37CB040913A for ; Thu, 4 Jun 2026 11:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780571243; cv=none; b=s5EAljHVTtQ8DlpPqyS/+EK6Cl+OsnedMFQip3Z7TXnsBAYDNGd/Kahu3SSX29VELxYNtij3n4SHqnLB+nssIhvNnpniexApwSXSc9NtiLBRl98XqGvW8237epg6qUKH4tl/tqktJt+06/TjXsrM8/+UGCjml2xoH3LL2Z6Apb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780571243; c=relaxed/simple; bh=tBgp5vRQFOl7a8nBW4mepV+LziDESM9zSsnbBm6iXLQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=XY6jWsZfbNXhfuZbIBEyAgWIufkvBQf3dOFSDV5PWdKdSkPDB666jFixoHReBxLdkO/PDMPcMtpFZMDn01NIvll3hPNbUPRifYvFxiBjm+RyWr+AQBJpkkAnU+eKmlY+RAgveS1RI0HXsn5sxEYmrTeBDQZ4RNbEi8SO541+7Ps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X6bP4QGV; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jtejQYAR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X6bP4QGV"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jtejQYAR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780571241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AK5uzOYSCwraOmBHC9lcOGmnhT5oZxWafdDkYZzfB28=; b=X6bP4QGVYNF7Z76bUUhOHAM+6QBR7zmKQSSUw5rFMuRSlcSq5jETZK/Lvv7fhAmXnFsp5f Y59HFebyO1ma4M8GwOYFBU/duTqEzlkcWc8crF947Je0CIBdcoN3uo4+wwtoSjAPNFx3sy uP6A9cU7xGABRrZTsflPCWSAkp8zYuI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-546-YkKq1ea6Mb6G_ubFNYRXMA-1; Thu, 04 Jun 2026 07:07:20 -0400 X-MC-Unique: YkKq1ea6Mb6G_ubFNYRXMA-1 X-Mimecast-MFC-AGG-ID: YkKq1ea6Mb6G_ubFNYRXMA_1780571239 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-45efa2f7009so373455f8f.3 for ; Thu, 04 Jun 2026 04:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780571238; x=1781176038; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:cc:content-language:from :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=AK5uzOYSCwraOmBHC9lcOGmnhT5oZxWafdDkYZzfB28=; b=jtejQYARh1ZcFlts6Ajztfi8j+ryKKybSzck+arZ2zAuD/r7nOW7gRvEO7CgSjwPKk DRICOVnk+HWp5DKKCLYjjt28QickP2QiDbHa6JyCMtCQ5GbgBOZArWsP6VFgZgVKXuwJ 1vYRsrnl7PnULiz8sR6uIL49+SjShD4BJ+i90goi1bNHjm4fJg7RcAygjO6ZyYjmSR/D kJ3QTWbuMGPPQCESUjRQ/8nOdYDRPHlLz983GUTcb1R5OHIVjLGtndmmPaDnzmOZk0gq zLC+9F2tAShB6NYWrxjpBmXXm6amk0zIed6BCHSlI+5n0TR9bWyTvzQlaEfuStqj8uH/ a7NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780571238; x=1781176038; h=content-transfer-encoding:in-reply-to:cc:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AK5uzOYSCwraOmBHC9lcOGmnhT5oZxWafdDkYZzfB28=; b=D8Vz1vVm2jrB9X+mhxnXnkzRxj0VL8OA4jz+bshoLgIRdeQ+3A7tHQTnq52cN3xKyi +aLfzui+zuNlJbREyfMBw6ekfK2s4M31WBAmbZsxaUvQ7tMTj74xswvUUVoGGQOoL1XM k9dZYWGzspLDMiDKf6X+DEzRrte9YLkUl9jJuWCECISRr+isr8XJ2UF+fQ6r/2xKRzfU F9JsIr7SEcp3vKnRzonDsSqnQMFilEjVgqskIfhv5S7s7O5dE2HoG0FdweZ/tZHdUx9o DF4j9qFlr32bZcc3rtlybmD8TSKmp8kTCDAlJ0HpvXcUZI/JvV9MkhIj8eSfLm9qLCpF YLcQ== X-Forwarded-Encrypted: i=1; AFNElJ/LBz2kh8Fwe+oCTv4n08sAB1LUM51Y+M8OfsNQtIHns7FPtfdCNvq3eUvrXnwlvpoVDFumXXxhS4aFwtM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxio4YfokmmR6dHV68FHA94oV2tnRCRmIIhex8cVo3w5G1x4LMF VJqUMOtfC92WTyon33EsTUk3grzNlsY0LEt0Ki5Bt1w/k44PXLp5VaK+vjjOFwonkM9+dMrUNst 6s27CT69pTc5rMIxtx5TDq84ZD0M7YTZsflxu7vA68yU0z64krWaBZ5FFpdoaYZ9HaA== X-Gm-Gg: Acq92OGesB2er5B1WVXXGvjC+X+0lO8YWWdcLNhV1KhD6JutaU2Bpk8AR6e209n4ZBh TcW20f27+Cy4AdZ6ZsA9WnEQTlc6IcKJq7n/TV7wLKKxHuu3+X0faSxyvlvBGFzfvs97KoQrOdg ygvFCqEiI5oHvKGDazpF3W5daxDrsYcJ0M4o0tAr3cizhLp4ArbkstjvPSU5E+U/ODdER2BZ1K8 b9xccCRRlDiFmL/tInyEmnkZe/J4aJJS4aID9r9P3hiT8NZpjCM1h7udJITj5oGC6424guURdEm dT+WSrVQMtm5L8AS2FY9ELaOz/J1hZHhE0OUBv42Cl3MvTpg0/ExvUdIy5gVlp2WxxIGJhiK/5t MKYRRRivodKbVQzFKHuLXn95k60k8SZVaTQbDD017rPSUMsBvwAnX6mzg29TGoe5s/ts= X-Received: by 2002:a5d:640e:0:b0:43c:fc5c:a9fe with SMTP id ffacd0b85a97d-4602182bbe9mr8255851f8f.20.1780571238608; Thu, 04 Jun 2026 04:07:18 -0700 (PDT) X-Received: by 2002:a5d:640e:0:b0:43c:fc5c:a9fe with SMTP id ffacd0b85a97d-4602182bbe9mr8255812f8f.20.1780571238218; Thu, 04 Jun 2026 04:07:18 -0700 (PDT) Received: from [192.168.88.32] ([212.105.155.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f3529e0sm15396808f8f.28.2026.06.04.04.07.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 04:07:17 -0700 (PDT) Message-ID: <16b81f1a-ae24-4a05-a348-0259f8935378@redhat.com> Date: Thu, 4 Jun 2026 13:07:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 3/3] net: phy: as21xxx: force C45 OPs for AUTONEG To: Christian Marangi References: <20260601105342.28865-1-ansuelsmth@gmail.com> <20260601105342.28865-3-ansuelsmth@gmail.com> From: Paolo Abeni Content-Language: en-US Cc: Russell King , "David S. Miller" , Heiner Kallweit , Andrew Lunn , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org In-Reply-To: <20260601105342.28865-3-ansuelsmth@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/1/26 12:53 PM, Christian Marangi wrote: > With further testing with 2.5G NIC, it was discovered that the PHY > require the C45 OPs to configure and restart ANEG or speed higher than > 1G doesn't function correctly. > > To force C45 OPs with generic PHY function, clear the C22 bit from > devices_in_package bitmask. > > Fixes: 830877d89edc ("net: phy: Add support for Aeonsemi AS21xxx PHYs") > Signed-off-by: Christian Marangi Sashiko has a few comments here and on the previous patch: https://sashiko.dev/#/patchset/20260601105342.28865-1-ansuelsmth%40gmail.com could you please double check them?