mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: neil.armstrong@linaro.org
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Jagan Teki <jagan@edgeble.ai>,
	Jessica Zhang <quic_jesszhan@quicinc.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Linus Walleij <linus.walleij@linaro.org>,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	stable@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: panel: jd9365da-h3: fix reset signal polarity
Date: Mon, 30 Sep 2024 18:24:44 +0200	[thread overview]
Message-ID: <16bd6bc2-8f10-4b99-9903-6e9f0f8778d8@linaro.org> (raw)
In-Reply-To: <20240930110537.dbbd51824c2bb68506e2f678@hugovil.com>

On 30/09/2024 17:05, Hugo Villeneuve wrote:
> On Mon, 30 Sep 2024 16:38:14 +0200
> Neil Armstrong <neil.armstrong@linaro.org> wrote:
> 
>> Hi,
>>
>> On 27/09/2024 15:53, Hugo Villeneuve wrote:
>>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>>
>>> In jadard_prepare() a reset pulse is generated with the following
>>> statements (delays ommited for clarity):
>>>
>>>       gpiod_set_value(jadard->reset, 1); --> Deassert reset
>>>       gpiod_set_value(jadard->reset, 0); --> Assert reset for 10ms
>>>       gpiod_set_value(jadard->reset, 1); --> Deassert reset
>>>
>>> However, specifying second argument of "0" to gpiod_set_value() means to
>>> deassert the GPIO, and "1" means to assert it. If the reset signal is
>>> defined as GPIO_ACTIVE_LOW in the DTS, the above statements will
>>> incorrectly generate the reset pulse (inverted) and leave it asserted
>>> (LOW) at the end of jadard_prepare().
>>
>> Did you check the polarity in DTS of _all_ users of this driver ?
> 
> Hi Neil,
> I confirmed that no in-tree DTS is referencing this driver. I did a
> search of all the compatible strings defined in the
> "jadard,jd9365da-h3.yaml" file. I also did the same on Debian code
> search.


OK then:
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

> 
> Hugo.
> 
> 
>>
>> Neil
>>
>>>
>>> Fix reset behavior by inverting gpiod_set_value() second argument
>>> in jadard_prepare(). Also modify second argument to devm_gpiod_get()
>>> in jadard_dsi_probe() to assert the reset when probing.
>>>
>>> Do not modify it in jadard_unprepare() as it is already properly
>>> asserted with "1", which seems to be the intended behavior.
>>>
>>> Fixes: 6b818c533dd8 ("drm: panel: Add Jadard JD9365DA-H3 DSI panel")
>>> Cc: <stable@vger.kernel.org>
>>> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>> ---
>>>    drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c | 8 ++++----
>>>    1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
>>> index 44897e5218a69..6fec99cf4d935 100644
>>> --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
>>> +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
>>> @@ -110,13 +110,13 @@ static int jadard_prepare(struct drm_panel *panel)
>>>    	if (jadard->desc->lp11_to_reset_delay_ms)
>>>    		msleep(jadard->desc->lp11_to_reset_delay_ms);
>>>    
>>> -	gpiod_set_value(jadard->reset, 1);
>>> +	gpiod_set_value(jadard->reset, 0);
>>>    	msleep(5);
>>>    
>>> -	gpiod_set_value(jadard->reset, 0);
>>> +	gpiod_set_value(jadard->reset, 1);
>>>    	msleep(10);
>>>    
>>> -	gpiod_set_value(jadard->reset, 1);
>>> +	gpiod_set_value(jadard->reset, 0);
>>>    	msleep(130);
>>>    
>>>    	ret = jadard->desc->init(jadard);
>>> @@ -1131,7 +1131,7 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
>>>    	dsi->format = desc->format;
>>>    	dsi->lanes = desc->lanes;
>>>    
>>> -	jadard->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>>> +	jadard->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
>>>    	if (IS_ERR(jadard->reset)) {
>>>    		DRM_DEV_ERROR(&dsi->dev, "failed to get our reset GPIO\n");
>>>    		return PTR_ERR(jadard->reset);
>>>
>>> base-commit: 18ba6034468e7949a9e2c2cf28e2e123b4fe7a50
>>
>>
> 
> 


  reply	other threads:[~2024-09-30 16:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 13:53 Hugo Villeneuve
2024-09-30 14:38 ` Neil Armstrong
2024-09-30 15:05   ` Hugo Villeneuve
2024-09-30 16:24     ` neil.armstrong [this message]
2025-02-04 17:46       ` Hugo Villeneuve
2025-02-13 11:42         ` Linus Walleij
2025-02-13 16:42           ` neil.armstrong
2025-02-13 17:07 ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16bd6bc2-8f10-4b99-9903-6e9f0f8778d8@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hugo@hugovil.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jagan@edgeble.ai \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®