From: Richard Leitner <richard.leitner@skidata.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: <a.zummo@towertech.it>, <linux-rtc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] rtc: s35390a: clarify INT2 pin output modes
Date: Wed, 22 May 2019 09:49:33 +0200 [thread overview]
Message-ID: <16bd943f-ccae-c3a5-59d3-b429c12c8155@skidata.com> (raw)
In-Reply-To: <20190521155424.GH3274@piout.net>
On 21/05/2019 17:54, Alexandre Belloni wrote:
> Hello,
>
> This seems good to me but...
>
> On 21/05/2019 16:20:22+0200, Richard Leitner wrote:
>> --- a/drivers/rtc/rtc-s35390a.c
>> +++ b/drivers/rtc/rtc-s35390a.c
>> @@ -45,12 +45,13 @@
>> /* flag for STATUS2 */
>> #define S35390A_FLAG_TEST 0x01
>>
>> -#define S35390A_INT2_MODE_MASK 0xF0
>> -
>> +/* INT2 pin output mode */
>> +#define S35390A_INT2_MODE_MASK 0x0E
>> #define S35390A_INT2_MODE_NOINTR 0x00
>> -#define S35390A_INT2_MODE_FREQ 0x10
>> -#define S35390A_INT2_MODE_ALARM 0x40
>> -#define S35390A_INT2_MODE_PMIN_EDG 0x20
>> +#define S35390A_INT2_MODE_ALARM 0x02 /* INT2AE */
>> +#define S35390A_INT2_MODE_PMIN_EDG 0x04 /* INT2ME */
>> +#define S35390A_INT2_MODE_FREQ 0x08 /* INT2FE */
>> +#define S35390A_INT2_MODE_PMIN 0x0C /* INT2ME | INT2FE */
>>
>
> While you are at it you may as well use BIT().
Sure, will change that for v2.
regards;Richard.L
next prev parent reply other threads:[~2019-05-22 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 14:20 [PATCH 0/3] rtc: s35390a: uie_unsupported and minor fixes Richard Leitner
2019-05-21 14:20 ` [PATCH 1/3] rtc: s35390a: clarify INT2 pin output modes Richard Leitner
2019-05-21 15:54 ` Alexandre Belloni
2019-05-22 7:49 ` Richard Leitner [this message]
2019-05-21 14:20 ` [PATCH 2/3] rtc: s35390a: set uie_unsupported Richard Leitner
2019-05-21 14:20 ` [PATCH 3/3] rtc: s35390a: introduce struct device in probe Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16bd943f-ccae-c3a5-59d3-b429c12c8155@skidata.com \
--to=richard.leitner@skidata.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®