From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A987AC76196 for ; Thu, 6 Apr 2023 18:15:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240033AbjDFSPN (ORCPT ); Thu, 6 Apr 2023 14:15:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240050AbjDFSPK (ORCPT ); Thu, 6 Apr 2023 14:15:10 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5825C86A8 for ; Thu, 6 Apr 2023 11:15:08 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id 11so3473287ejw.0 for ; Thu, 06 Apr 2023 11:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680804906; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6oBB6rYPRVsTiSqqWKemxM9/0vuuZy9SiI096Y0Oy3U=; b=m1S+okcxwXDcJYBb7Lp3dofmFYmwovcO2X/wgdvcL8kbt2JVauvprB0QAmRCqwxiyL UXlNijZLRP/XscA8vLwob+y8S5X3FCxMAkmm+hhkNhbpYLwpILGB4YbmmJTisTbf6ihP QVRH3HkDVgCZ521TGazpen8lA9T8oxAD1vLfTMu3v/I0lmc/bxO86gW/iGT/UwMyi4YP bGc2sRQs9mCyfyTOKUauMT0uZOtaLCTD/Jr6oDMrd/crowXK8QGB/HUaFz3rfx9fEfsi DYOoIPl+DHc3bVnOf9+6E1X9i7ai53CgylTrusfALg3EsUP4ukMWXKXOZZ8XM9RUZNCN n3KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680804906; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6oBB6rYPRVsTiSqqWKemxM9/0vuuZy9SiI096Y0Oy3U=; b=kT/ffu+GLLd2DtgL48Tucvf7q5usTg0UywHibjMQQIf2mFeCeTIHxJZ5oZ9RcEJOnz BAEKIp1ANZgZiybGWtZPueRdy9ONb8lhOh6HYnd1oi7lsm9d95lZBPdrZ6FlazKVMklp qGJ/PkEBw+PAA1bepDclmsfe/dMX/7JQR1tw1bV/493+iKs5+Gr5hQIyAJWu983JXtM7 vrlmXPdXeR10jSe6ygIUVs2r0IPlLiRTn9gF00TO5HVFjyJHS9cXBFpkE1tCgORbYwQG IZauQjK7G2gCyqC/vfssgZek4jmNgtqBoT/nkvgmv3X3On1pIULmv4eLkK6Ue2mbJDB6 bisg== X-Gm-Message-State: AAQBX9dovgCV1ZLEpuuS9FD8v1n1VDpeSURPWW033KpLJruCoDLOSWz9 L9/S6f6qL66J0s/A+O0sNRpzbw== X-Google-Smtp-Source: AKy350YGb4hztmcQTJNpcO2q5BKDY7104we4V4xx/57nKA31ObFU4Fdll08/Ztl8jTR6gFFDG8x52w== X-Received: by 2002:a17:906:2559:b0:947:55ad:dd00 with SMTP id j25-20020a170906255900b0094755addd00mr6862795ejb.26.1680804906625; Thu, 06 Apr 2023 11:15:06 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed? ([2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed]) by smtp.gmail.com with ESMTPSA id cw10-20020a170906478a00b009486efb9192sm1133427ejc.11.2023.04.06.11.15.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 11:15:06 -0700 (PDT) Message-ID: <16bf1f2e-474d-f2ce-a1c9-2f6a089199d5@linaro.org> Date: Thu, 6 Apr 2023 20:15:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 8/8] regulator: fan53555: Add support for RK860X Content-Language: en-US To: Cristian Ciocaltea , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Bjorn Andersson , Joseph Chen , Ezequiel Garcia Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@collabora.com References: <20230406171806.948290-1-cristian.ciocaltea@collabora.com> <20230406171806.948290-9-cristian.ciocaltea@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20230406171806.948290-9-cristian.ciocaltea@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2023 19:18, Cristian Ciocaltea wrote: > Extend the existing fan53555 driver to support the Rockchip RK860X > regulators. > > RK8600/RK8601 are pretty similar to the FAN53555 regulators. > > RK8602/RK8603 are a bit different, having a wider output voltage > selection range, from 0.5 V to 1.5 V in 6.25 mV steps. They also use > additional VSEL0/VSEL1 registers for the voltage selector, but the > enable and mode bits are still located in the original FAN53555 specific > VSEL0/VSEL1 registers. > > Signed-off-by: Cristian Ciocaltea > --- > drivers/regulator/fan53555.c | 121 ++++++++++++++++++++++++++++++++++- > 1 file changed, 118 insertions(+), 3 deletions(-) > > diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c > index acf14ba7aaa6..130f3dbe9840 100644 > --- a/drivers/regulator/fan53555.c > +++ b/drivers/regulator/fan53555.c > @@ -26,6 +26,9 @@ > #define FAN53555_VSEL0 0x00 > #define FAN53555_VSEL1 0x01 > > +#define RK8602_VSEL0 0x06 > +#define RK8602_VSEL1 0x07 > + > #define TCS4525_VSEL0 0x11 > #define TCS4525_VSEL1 0x10 > #define TCS4525_TIME 0x13 > @@ -55,6 +58,7 @@ > > #define FAN53555_NVOLTAGES 64 /* Numbers of voltages */ > #define FAN53526_NVOLTAGES 128 > +#define RK8602_NVOLTAGES 160 > > #define TCS_VSEL0_MODE BIT(7) > #define TCS_VSEL1_MODE BIT(6) > @@ -64,6 +68,8 @@ > enum fan53555_vendor { > FAN53526_VENDOR_FAIRCHILD = 0, > FAN53555_VENDOR_FAIRCHILD, > + FAN53555_VENDOR_ROCKCHIP, /* RK8600, RK8601 */ > + RK8602_VENDOR_ROCKCHIP, /* RK8602, RK8603 */ Acked-by: Krzysztof Kozlowski Best regards, Krzysztof