From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C860C433DB for ; Tue, 23 Mar 2021 11:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3A36619BB for ; Tue, 23 Mar 2021 11:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230461AbhCWL1G (ORCPT ); Tue, 23 Mar 2021 07:27:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50960 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230165AbhCWL0t (ORCPT ); Tue, 23 Mar 2021 07:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616498804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CO7ddAXo7AW4IVD6z1X02gzoos7uqwcpTrAx3rTQHIE=; b=epEGqrD0PF+latJWr2eb/YLYO92AXpYuQe7JrelI30uRRiQ4nTY7OJQBQ5HJDU297Nw/9s sXg9R1m542AUbdE83u6S9kIKdbvzBfa0FgLYXSwpWtGi62PqOTp/9XTHnyFKJJqeYYrq8Q EEiA8OXldWoukTZxzxTALZL6rLD/sfQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-bLs84uwNPVaNMEF3YIU1AQ-1; Tue, 23 Mar 2021 07:26:40 -0400 X-MC-Unique: bLs84uwNPVaNMEF3YIU1AQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5EC6110082E0; Tue, 23 Mar 2021 11:26:37 +0000 (UTC) Received: from [10.36.115.54] (ovpn-115-54.ams2.redhat.com [10.36.115.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD45F19744; Tue, 23 Mar 2021 11:26:28 +0000 (UTC) Subject: Re: [PATCH v1 2/3] kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM resources To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Greg Kroah-Hartman , Dan Williams , Daniel Vetter , Mauro Carvalho Chehab , Dave Young , Baoquan He , Vivek Goyal , Dave Hansen , Keith Busch , Michal Hocko , Qian Cai , Oscar Salvador , Eric Biederman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Tom Lendacky , Brijesh Singh , x86@kernel.org, kexec@lists.infradead.org References: <20210322160200.19633-1-david@redhat.com> <20210322160200.19633-3-david@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <16bfac8e-cee1-c8ce-14f1-70e697e4f2f1@redhat.com> Date: Tue, 23 Mar 2021 12:26:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.03.21 12:08, Andy Shevchenko wrote: > On Mon, Mar 22, 2021 at 05:01:59PM +0100, David Hildenbrand wrote: >> It used to be true that we can have system RAM only on the first level >> in the resourc tree. However, this is no longer holds for driver-managed >> system RAM (i.e., dax/kmem and virtio-mem). >> >> The function walk_mem_res() only consideres the first level and is >> used in arch/x86/mm/ioremap.c:__ioremap_check_mem() only. We currently >> fail to identify System RAM added by dax/kmem and virtio-mem as >> "IORES_MAP_SYSTEM_RAM", for example, allowing for remapping of such >> "normal RAM" in __ioremap_caller(). > > Here I dunno, but consider to add Fixes tag if it fixes known bad behaviour. Haven't observed it in the wild. We can add the same fixes tags as to patch #1. -- Thanks, David / dhildenb