From: Guenter Roeck <linux@roeck-us.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'
Date: Wed, 14 Sep 2016 07:33:43 -0700 [thread overview]
Message-ID: <16c144a0-e967-e35a-2abd-9942d0d6c944@roeck-us.net> (raw)
In-Reply-To: <CACRpkdbs8ZDw6tC-6OgtiRve7xogbXvsdqauxNPssbphmO9pGg@mail.gmail.com>
On 09/14/2016 12:19 AM, Linus Walleij wrote:
> On Wed, Sep 14, 2016 at 5:20 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>
>> So, in other words, lots of bugs here. Nevertheless, I would suggest to keep
>> using postcore_initcall(), at least until it is sure that all gpio clients handle
>> -EPROBE_DEFER
>> correctly.
>
> So can I just revert this patch in isolation? None of the other patches
> depend on it?
>
Good question, if this was part of a series. If it was and can not be removed
in isolation, it nevertheless introduces a regression. Obviously there was
a reason for using postcore_initcall (which is quite evident in the crash),
and I don't think it is a good idea to just change it without addressing
the reason(s) first. Who knows what other platforms crash because of this
change.
Guenter
next prev parent reply other threads:[~2016-09-14 14:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 3:20 Guenter Roeck
2016-09-14 7:19 ` Linus Walleij
2016-09-14 14:33 ` Guenter Roeck [this message]
2016-09-15 12:19 ` Linus Walleij
2016-09-15 13:18 ` Vladimir Zapolskiy
2016-09-15 13:45 ` Vladimir Zapolskiy
2016-09-15 13:55 ` Linus Walleij
2016-09-15 13:18 ` Vladimir Zapolskiy
2016-09-15 13:35 ` Vladimir Zapolskiy
2016-09-15 14:23 ` Uwe Kleine-König
2016-09-15 14:35 ` Guenter Roeck
2016-09-15 14:46 ` Uwe Kleine-König
2016-09-16 2:24 ` Guenter Roeck
2016-09-18 0:08 ` Shawn Guo
2016-09-18 0:59 ` Guenter Roeck
2016-09-18 11:24 ` Linus Walleij
2016-09-20 12:55 ` Shawn Guo
2016-09-20 13:53 ` Vladimir Zapolskiy
2016-09-20 14:18 ` Shawn Guo
2016-09-20 21:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16c144a0-e967-e35a-2abd-9942d0d6c944@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®